GNOME Bugzilla – Bug 585659
Last modified: 2011-12-29 05:36:39 UTC
I am sorry too late answer to Jason.
I send new patch. This patch is essential part of new iagno with next features.
Head, Back, Forward, Last.
Window size and position are saved.
Changeable background color.
Flipping tile and fast move.
Row and column label.
Flip final results.
File save File open.
Valid squares mark.
Last move mark.
On preference dialog, Human is not translated.
Created attachment 136508 [details] [review]
new iagno patch
I test this patch on Ubuntu-9.04-i386 and Fedora-11-x86-64.
Created attachment 136509 [details] [review]
New three tiles
This patch include disk.svg, marble.svg and sun_and_star.svg.
Please delete clasic.png and woodtrim.png file from iagno directory.
Created attachment 136510 [details]
I guess this is the continuation of bug 444602 ?
Could you please comment a bit on which issues that were raised by the reviewers in the previous bug are fixed in this new patch? And also, did you do this as a monolithic patch, or do you have your own repo and did this as a series of smaller patches that would be easier to review? If so, can you tell the repo URL, or attach a patch series (git-format-patch) ? Thanks!
Created attachment 137009 [details] [review]
deleteing png files patch
I planed for easy to view, so split them, and send git-format-patch.
1. I think iagno is too old, iagno should have resizeable window
and tool bar.(for Bug #560069, #581900, #543387, #451906)
2. Iagno hangs at starting network game on Japanese language,
(2.26.1 ubuntu-9.04 and fedora-11) same as Bug #487071.
This bug is occurred by the same reason as Bug #519232.
This bug had not occurred until gtk was changed at some years ago.
I test this bug with Bug #519232 Comment #6 patch.
So Bug #487071 and Bug #519232 are fixed with the same patch.
3. Current network game has many bugs.
3.1 If an error occurred, server sends sync, but client does not
support sync, so iagno hangs.
3.2 Player can not play again, iagno does not support.
3.3 Player can not back to normal game, iagno does not support.
3.4 Server.c, has some bugs around play again.
After a game over, one player leave, and connect again,
another player sends PLAY_AGAIN, but he can not play again.
3.5 Bug #582795 is fixed in this patch (destroy network dialog).
This bug is about gnect, but iagno and gnibbles too.
Created attachment 137010 [details] [review]
network game patch
Created attachment 137011 [details] [review]
Tango stile flipping tile (for bug #573544)
Created attachment 137013 [details]
Network game screenshot
Created attachment 137374 [details] [review]
This patch appends next to new iagno.
1. Show valid squares (with small circle).
2. Show last move (with blinking small circle, for Bug #118996).
3. Show timer.
Please change hint comment more better.
2. Watch cursor
While the computer is thinking, arrow cursor is changed to watch cursor.
(for Bug #443449)
3. An player can open new-iagno from ggz-gtk.
1. In gnothello.c main(),
game_init () was moved before properties_apply_changes ();
2. In ggz_network.c get_sync(),
game_init() was moved after old server, and new sever program was changed.
3. In ggz_network.c ggz_closed(),
if (ggzmod) was appended.
4. In ggz_network.c on_network_activate,
gtk_widget_show() was moved before gtk_notebook_set_current_page().
1. In ggz_network.c, ggz_closed() function,
gtk_widget_destroy (widget[GGZBOX]) was changed with
Created attachment 137375 [details] [review]
This patch appends save and open menu.
Created attachment 137376 [details]
Options screen shot
Created attachment 137502 [details] [review]
This patch is not one of the series, all(0001-0007) in one and change directory.
This patch change direct iagno to iagno2.
This series is over. Thank you.
1. Sometimes watch cursor is not changed to arrow cursor.
2. In ggz_network.c, ggz_closed() function,
gtk_widget_hide () was backed to gtk_widget_destroy ().
At a player connect again after the same name was used,
ggzbox is not cleared.
1. Directory was changed. ("data", "pixmaps" and "src" was appended.)
2. MAIN_PAGE and NETWORK_PAGE was changed to main_page and network_page vars.
3. In ggz_network.c, some functions position was moved.
4. In save.c, create_file_dialog () was rewrited.
5. "on_hint_activate ()" was moved from gnothello.c to options.c.
Created attachment 144117 [details] [review]
I modified conflict with previous patch.
Created attachment 144118 [details] [review]
Created attachment 144119 [details] [review]
Created attachment 144120 [details] [review]
Iagno new AI
Hash table, bit board, new evaluate function, opening book, etc
Created attachment 144121 [details] [review]
opening book data
Created attachment 144123 [details] [review]
evaluation functions value
Please use lxsplit to join.
Created attachment 144124 [details] [review]
Created attachment 144125 [details] [review]
Created attachment 144126 [details]
Created attachment 145711 [details] [review]
Black was weaker than White.
Speed upped (20~30%)
The deepest middle search is 17, Win-Loss search is 25 empties.
Created attachment 145712 [details] [review]
Created attachment 145713 [details] [review]
Evaluation fuctions value1
Created attachment 145714 [details] [review]
Evaluation functions value2
Created attachment 145715 [details] [review]
Evaluation functions value3
Created attachment 145716 [details] [review]
Created attachment 173995 [details]
I changed for gnome-2-32.
I test this patch on Ubuntu-10.10 and Fedora-14.
I could configure with next option "--enable-games=iagno" on Ubuntu-10.10
and Fedora-13, but could not on Fedora-14. so I configured with no options
1. mistaking at checking the validity of C8.
1. opening book to more bigger.
2. for beginners to more weaker and for expert to more stronger.
(for Bug 601596)
3. runable without opening book and hash.
4. appearance (Please see Screen shot)
5. deleted ggz parts.
Now iagno(16-play) is as strong as OO7(7-ply Logistello).
Created attachment 173996 [details] [review]
Created attachment 173997 [details] [review]
Created attachment 173998 [details]
Please join next three patch with "lxsplit" after expansed.
Created attachment 174000 [details] [review]
Created attachment 174002 [details] [review]
Created attachment 174003 [details] [review]
Created attachment 174004 [details] [review]
I *want* to merge your work but you aren't making it easy. I asked you to make the changes in to small digestible commits so that we can review every step of the changes for correctness. Instead you have, again, dumped the entire finished code base on us.
Anyway the UI freeze was 4 days ago, this is delayed until 3.2.
Created attachment 189796 [details] [review]
new iagno patch
This patch is the first step of new iagno.
I test this patch on ubuntu-11.04-desktop-amd64 and Fedora-15-x86-64-DVD.
but didn't test on 32 bit OS.
`menu_proxy_module_load': iagno: undefined symbol: menu_proxy_module_load
(iagno:18109): Gtk-WARNING **: Failed to load type module: (null)
This bug is the same as other games.
I can not understand about global-menu-bar yet, so iagno doesn't support
Many thanks for your help.
Created attachment 189797 [details]
I cleated new sun_and_star.svg from bug #645217.
It's very beautiful, but too heavy for tile.
It takes a long time to change board size.
Please test this svg.
Created attachment 189798 [details]
new iagno screenshot
Break the giant patch in to small, reviewable, individually buildable changes which are self contained. You can do this by doing git rebase -i and giving your commit the "edit" operation.
See the instructions in the section 'SPLITTING COMMITS' in the "git rebase --help"
Created attachment 191616 [details] [review]
Open and save move text patch
Created attachment 191617 [details] [review]
Opening book patch
Created attachment 191618 [details] [review]
Opening book data
Created attachment 191619 [details] [review]
Transposition table patch
Created attachment 191620 [details] [review]
New evaluate function patch
Created attachment 191621 [details] [review]
Evaluate function's value 001
Created attachment 191622 [details] [review]
Evaluate function's value 002
Created attachment 191623 [details] [review]
Evaluate function's value 003
Please join above three patch useing lxsplit after extract them.
(In reply to comment #49)
> Created an attachment (id=191623) [details] [review]
> Evaluate function's value 003
> Please join above three patch useing lxsplit after expand them.
Created attachment 191624 [details] [review]
Created attachment 191625 [details] [review]
Multi ProbCut parameter
Created attachment 191626 [details] [review]
Created attachment 191627 [details] [review]
Calculate MPC parameter patch
Created attachment 191628 [details] [review]
Setup board patch
We have just ported Iagno from C to Vala (bug 664942) so these patches no longer apply. I spent a lot of time reviewing these before the port and tried to see if we could apply them before the port but they proved to be too complex. The good news is the new version should be a lot simpler to modify.
The patches here seem to be specifically for a new computer player algorithm, if that is so you could update these patches and open a new bug, i.e. "Improved Computer Player" with a patch that improves the computer player. This bug should contain a single patch file that changes as little as possible in the current code. The patch will be judged on criteria like:
- Is it easy to read and debug?
- Does the game remain easy to play for beginners?
- Is the additional complexity of the code worth it (it will have to be maintained for a number of years).
If you have different features you want to improve, they should be in different bugs.
I've used your scalable icons, but they have some performance issues to render and some clarity issues. Could you have a look at bug 664983 and update the icons?