After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561886 - Location bar search for bookmarks is dogslow and does too much work
Location bar search for bookmarks is dogslow and does too much work
Status: RESOLVED WONTFIX
Product: epiphany
Classification: Core
Component: Bookmarks
3.4.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 582850 (view as bug list)
Depends on:
Blocks: 755518
 
 
Reported: 2008-11-22 01:51 UTC by Jean-François Fortin Tam
Modified: 2016-10-07 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jean-François Fortin Tam 2008-11-22 01:51:56 UTC
When the user types in the location bar or the bookmark dialog's search box, do not actually launch the query until the user has typed >=3 characters.

I would presume that doing that would improve performance in orders of magnitude, or at least tenfold. Some people type very slowly, or are just dumb (like me) and pause after typing the first letter. Epiphany then launches the search for the letter "e", hogs the CPU and returns hundreds of results for nothing.

For what it's worth, Evolution does this (requiring 3 characters before launching a search) for its contact autocompletion feature.
Comment 1 Reinout van Schouwen 2008-11-25 14:02:26 UTC
Thanks for taking the time to report this bug. This bug has been addressed in a newer Epiphany version that the one you are using.

By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME.
Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.
Comment 2 Jean-François Fortin Tam 2010-02-26 17:05:05 UTC
Reopening as 2.29.90.1 still tries to search when I type even a single character. While it has much better searching performance (nice!), it still seems like a big waste, to me, to search for anything under 3 characters...?
Comment 3 Jean-François Fortin Tam 2012-09-06 01:05:47 UTC
Okay, reconfirming this. With Epiphany 3.4, and I still get slowdowns and sometimes complete lockups for 30 seconds.

There's a very easy way to trigger this bug.

1) Have a decent amount of bookmarks:

jeff@kusanagi:~/.gnome2/epiphany$ grep 'resource="http' bookmarks.rdf |wc -l
2485

jeff@kusanagi:~/.gnome2/epiphany$ du -h bookmarks.rdf 
864K	bookmarks.rdf



2) In the location bar, type on letter and immediately erase it; repeat this operation repeatedly and very quickly. Deadlock guaranteed. It might sound extreme to you, but this repetition just exacerbates the problem I encounter all the time during normal usage.

If I was using a Pentium II with 64 MB of RAM and a Voodoo2 GPU, I'd understand. But on a Core2 Quad processor with a solid state drive, this is completely unacceptable, especially if you want to consider yourself a modern, fast and lightweight browser. This makes a bad impression on webkit.
Comment 4 Jean-François Fortin Tam 2012-10-08 02:49:16 UTC
*** Bug 582850 has been marked as a duplicate of this bug. ***
Comment 5 Michael Catanzaro 2016-09-28 16:50:11 UTC
Hi, the bookmarks code has been rewritten from scratch. When you have a convenient opportunity to test the new version of the code (which will be present in Epiphany 3.23.1) please check to see if your issue is still a problem, and reply here. Thanks!
Comment 6 Michael Catanzaro 2016-10-07 21:28:54 UTC
Hi, this is a mass close of all bugs in the NEEDINFO state. If you think this bug was closed improperly, just leave a comment, thanks!