After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554455 - "Advanced search -> Include threads" does not work
"Advanced search -> Include threads" does not work
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[disk-summary]
: 557020 (view as bug list)
Depends on:
Blocks: 543389
 
 
Reported: 2008-09-30 15:28 UTC by Stanislav Brabec
Modified: 2008-10-22 04:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Proposed patch (1.80 KB, patch)
2008-10-07 06:08 UTC, Srinivasa Ragavan
committed Details | Review
evolution-data-server-thread-search.patch (864 bytes, patch)
2008-10-09 12:06 UTC, Stanislav Brabec
rejected Details | Review

Description Stanislav Brabec 2008-09-30 15:28:44 UTC
evolution 2.23.92 openSUSE 11.1 beta 1 x86_64

"Advanced search -> Include threads" does nor work

I tried to create Advanced search and virtual folder "Threads I participate on":

Advanced search -> Include threads -> All related
Sender -> Contains -> sbrabec

It seems that "Advanced search -> Include threads -> All related" does nor work and behaves like "Include threads -> None".

Marking as Major: This feature saves a lot of time when searching for answers to my mails in high traffic mailing lists.

Related: bug 503013 (feature request for tools to manipulate high traffic mailing lists)
Comment 1 Stanislav Brabec 2008-09-30 15:37:34 UTC
Note that it is a regression: It works well in evolution-2.22.1.1
Comment 2 Srinivasa Ragavan 2008-10-01 03:58:23 UTC
Yep, it is known, not to work with disk summary branch. 

Hmm, I can make it fallback to old in-memory search model, for thread-based-searches. I have heard this from more people. I should fix this up asap.
Comment 3 Patrick Ohly 2008-10-03 21:52:02 UTC
+1 from me for fixing this ASAP. I depend on this feature a lot to the point that I'll rather continue to use 2.22.x instead of upgrading.
Comment 4 Srinivasa Ragavan 2008-10-07 06:08:08 UTC
Created attachment 120089 [details] [review]
Proposed patch

This will make the code fallback to old search model for thread search. With this even vfolders must work.
Comment 5 Stanislav Brabec 2008-10-09 12:06:40 UTC
Created attachment 120263 [details] [review]
evolution-data-server-thread-search.patch

As attached patch did not fit on 2.24.0, I tried to backport it. I can confirm, that attachec patch works.
Comment 6 Srinivasa Ragavan 2008-10-13 07:54:40 UTC
The stable code base for 2.24.1 is changed and the patch I had attached was for that :-) Anyways thanks for the test. I will commit it asap for 2.24.1 which we would be picking for code-11
Comment 7 Srinivasa Ragavan 2008-10-14 05:25:41 UTC
fixed to stable/trunk. Should be there in 2.24.1
Comment 8 Akhil Laddha 2008-10-21 04:41:28 UTC
*** Bug 557020 has been marked as a duplicate of this bug. ***
Comment 9 Matt McCutchen 2008-10-21 16:36:29 UTC
I built a modified version of Fedora's evolution-data-server-2.24.0-1.fc9 with the patch from comment #5 (posted at http://mattmccutchen.net/rpm/), but the problem is not fixed.  I guess I will try to either fix the backport or rebuild with the tagged evolution-data-server 2.24.1 code.
Comment 10 Matt McCutchen 2008-10-22 03:22:18 UTC
Actually, the problem seems not to be completely fixed in the trunk; see bug 557348.
Comment 11 Srinivasa Ragavan 2008-10-22 04:18:58 UTC
Matt, its about the expression, not refreshing the cache.  I would fix it.