After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550491 - Export using album data
Export using album data
Product: rhythmbox
Classification: Other
Component: Removable Media
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 557441 570595 (view as bug list)
Depends on: 550481
Reported: 2008-09-02 15:29 UTC by Bastien Nocera
Modified: 2009-06-19 04:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

cute hack (6.56 KB, patch)
2008-09-09 13:36 UTC, Jonathan Matthew
needs-work Details | Review
use entry extra metadata, add ui (18.44 KB, patch)
2009-03-28 10:42 UTC, Jonathan Matthew
none Details | Review
better ui (copied from sound-juicer) (29.64 KB, patch)
2009-06-17 09:05 UTC, Jonathan Matthew
committed Details | Review
screenshot (72.42 KB, image/png)
2009-06-17 09:09 UTC, Jonathan Matthew

Description Bastien Nocera 2008-09-02 15:29:13 UTC
+++ This bug was initially created as a clone of Bug #550481 +++

For compilations, I'd want to import to a directory containing "album artist - album name". Rhythmbox currently doesn't allow that.
Comment 1 Jonathan Matthew 2008-09-09 13:36:17 UTC
Created attachment 118357 [details] [review]
cute hack

Stores album-artist as a keyword ("rb-album-artist:<name>") on the audio CD entries, then uses that (if it exists) in the library source to construct filenames.  Not much good without a way to edit the album artist..
Comment 2 Bastien Nocera 2008-10-22 16:20:15 UTC
*** Bug 557441 has been marked as a duplicate of this bug. ***
Comment 3 Jonathan Matthew 2009-02-05 07:29:47 UTC
*** Bug 570595 has been marked as a duplicate of this bug. ***
Comment 4 Otto Kekäläinen 2009-02-05 07:53:43 UTC
This bug report is very vague on the problem. Please read the duplicates for a more clear description of the issue.

Also the topic should be changed to be more verbose, so that people could find this bug more easily and not make any more duplicates.

Also, as a usability expert, I'd like to point out that even if the issue can be resolved by changing the settings in Rhythmbox, that is too much work for most users. Rhythmbox should NOT scatter the contents of compilation albums into 15-25 folders BY DEFAULT.
Comment 5 Jonathan Matthew 2009-03-22 16:05:53 UTC
Proclaiming yourself to be a usability expert doesn't actually lend your arguments any weight, you know.  Not that I disagree at all.

Anyway, this should use the entry extra metadata mechanism rather than keywords.  Not sure what I was thinking.
Comment 6 Jonathan Matthew 2009-03-28 10:42:30 UTC
Created attachment 131546 [details] [review]
use entry extra metadata, add ui

This adds some stuff to the audio CD source to allow editing of the album artist (and sortname), but it's ugly.  I'm not sure it's a good idea to show the sortname there (track artist sortnames aren't shown anywhere or editable at all..).
Comment 7 Jonathan Matthew 2009-06-17 09:05:25 UTC
Created attachment 136807 [details] [review]
better ui (copied from sound-juicer)

I copied the album details bit from s-j (with the questionable addition of artist-sortname), and also hid the 'album' column in the track list, since it's now shown in the table above.
Comment 8 Jonathan Matthew 2009-06-17 09:09:48 UTC
Created attachment 136808 [details]
Comment 9 Bastien Nocera 2009-06-17 09:18:28 UTC
Instead of using rb_builder_boldify_label(), why not use the label attributes to set the labels as bold directly. This is a snippet from gnome-bluetooth:
           <property name="label" translatable="yes">Welcome to the Bluetooth device setup wizard</property>
              <attribute name="weight" value="bold"/>

Rest looks good to me.
Comment 10 Jonathan Matthew 2009-06-17 09:33:56 UTC
That only works with gtk 2.16, which I think is still a bit too new for us.  I think it looks slightly better without the bold anyway.
Comment 11 Jonathan Matthew 2009-06-19 04:35:14 UTC
committed (without the bold).