After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550481 - Update libjuicer from sound-juicer
Update libjuicer from sound-juicer
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 550488 550489 550491 550493 550494 550496
 
 
Reported: 2008-09-02 15:07 UTC by Bastien Nocera
Modified: 2008-09-05 06:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update from SVN trunk (25.07 KB, patch)
2008-09-02 15:15 UTC, Bastien Nocera 		none Details | Review
Updated (24.27 KB, patch)
2008-09-02 15:18 UTC, Bastien Nocera 		none Details | Review

Description Bastien Nocera 2008-09-02 15:07:15 UTC 
Might require some more re-licensing...
Comment 1 Bastien Nocera 2008-09-02 15:15:14 UTC 
Created attachment 117852 [details] [review]
Update from SVN trunk
Comment 2 Bastien Nocera 2008-09-02 15:18:19 UTC 
Created attachment 117854 [details] [review]
Updated

- Don't change the totem-pl-parser use
- Don't remove the solaris special casing
Comment 3 Jonathan Matthew 2008-09-03 12:33:05 UTC 
Looks fine to me, and seems to work.

The files changed here, except for sj-structures.h, all claim to be LGPL.  Do those actually need to be relicensed?
Comment 4 Bastien Nocera 2008-09-04 00:11:02 UTC 
And sj-error as well, both sets of files only Ross and myself touched.

Ross, anything against relicensing those to LGPL?

If not, I'll update and commit the patch tomorrow.
Comment 5 Ross Burton 2008-09-04 09:22:51 UTC 
Fine by me.
Comment 6 Bastien Nocera 2008-09-05 00:39:18 UTC 
So we didn't actually need the relicense. File new bugs if I broke anything.

2008-09-05  Bastien Nocera  <hadess@hadess.net>

	* configure.ac:
	* plugins/audiocd/Makefile.am:
	* plugins/audiocd/rb-audiocd-source.c (metadata_cb),
	(metadata_cancelled_cb), (rb_audiocd_load_metadata),
	(rb_audiocd_is_volume_audiocd):
	* plugins/audiocd/sj-*.[ch]:
	* plugins/audiocd/update-from-egg.sh: Update from sound-juicer
	trunk, adds CD-Text support via gvfs trunk, and Musicbrainz3
	(Closes: #550481)
Comment 7 Jonathan Matthew 2008-09-05 06:05:58 UTC 
I just added the missing sj-metadata-gvfs.*