After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 505720 - Hide toolbar in fullscreen mode
Hide toolbar in fullscreen mode
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
2.32.x
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 656814 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-26 12:40 UTC by AB
Modified: 2013-01-05 12:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.31/2.32


Attachments
Patch to remove toolbar from full screen reading view. (1.38 KB, patch)
2009-10-06 00:10 UTC, Tony Freeman
none Details | Review
Giver user better control over viewing fullscreen toolbar. (2.96 KB, patch)
2009-10-26 02:24 UTC, Tony Freeman
none Details | Review

Description AB 2007-12-26 12:40:31 UTC
If I want fullscreen what sense does a toolbar make?
Comment 1 Mathias Nedrebø 2008-06-09 22:25:06 UTC
I confirm this bug.

When I press F11, the document is not shown in full screen. There is still a menubar located at the top of the screen. The only way to get rid of this bar and get my document in full screen is to press F11 once more, then use the menus to totally disable the menubar and then press F11 a last time to enter fullscreen.
Comment 2 Reinout van Schouwen 2009-01-19 14:03:42 UTC
Confirming.
Comment 3 Wouter Bolsterlee (uws) 2009-02-09 14:58:33 UTC
A temporarily appearing toolbar would be nice, just like Totem.
Comment 4 Tony Freeman 2009-09-18 23:55:07 UTC
FEATURE REQUEST:  I actually signed up here on bugzilla just to make the suggestion that the toolbar be removed from fullscreen viewing.  Make it a user selectable option to keep it visible in fullscreen.  

Once that is done I suggest binding the ctrl-+ keys to go up the 'view' tree. and the ctrl-- binding to go down the view tree.
Comment 5 Tony Freeman 2009-09-19 00:37:57 UTC
Please excuse my ctrl-+ and ctrl-- suggestion ... evince already has it!  I don't know how I missed that.  I've been using evince for a very long time now ... 

Anyway ...

I had another idea about removing the toolbar from full screen mode.  How about putting all those toolbar options in the right-click menu?  You'll have to replace the zoom levels with a menu option called "zoom in" and "zoom out" (or similar).  

It would be really nice to have a full screen of nothing but document and scroll bars IF they are needed.
Comment 6 Tony Freeman 2009-10-04 22:30:55 UTC
FIX FOR THIS BUG (evince-2.26.2)

I'm not much of a coder, but this has been so irritating for me I took a look at the code myself and was able to fix this bug on my own machine.  I hope that someone would have a look at what I've done here and fix it for everyone else.

In a file called ev-window.c on beginning on line 3384 there is this:

[code]
	/* If the user doesn't have the main toolbar he/she won't probably want
	 * the toolbar in fullscreen mode. See bug #483048
	 */
	update_chrome_flag (window, EV_CHROME_FULLSCREEN_TOOLBAR,
			    (window->priv->chrome & EV_CHROME_TOOLBAR) != 0);
[/code]

The fix is to replace the 'update_chrome-flag ....' with this:

[code]
        update_chrome_flag (window, EV_CHROME_FULLSCREEN_TOOLBAR, FALSE);
[/code]

Please, GNOME people, fullscreen means full screen.  Remove that blasted toolbar ;-)
Comment 7 Reinout van Schouwen 2009-10-05 11:03:45 UTC
(In reply to comment #6)
> FIX FOR THIS BUG (evince-2.26.2)

Thanks for your contribution. Could you please attach a proper patch to this bug?
In http://live.gnome.org/Git/Developers you can find more information on how to do this. Thanks again!
Comment 8 Tony Freeman 2009-10-06 00:10:07 UTC
Created attachment 144862 [details] [review]
Patch to remove toolbar from full screen reading view.

Thanks
Comment 9 Tony Freeman 2009-10-26 02:24:29 UTC
Created attachment 146237 [details] [review]
Giver user better control over viewing fullscreen toolbar.

Changed the View menu to include a menu item that allows the user to
choose if he or she would like to see the toolbar in full screen reading view.  The new menu section looks like this:

# Toolbar
# Toolbar (Fullscreen)
# Side Pane

Added logic to ev-window.c to handle the fullscreen toolbar view based
on user view selection.
Comment 10 Praveen Thirukonda 2009-12-17 20:06:46 UTC
while at first i too was irked by this bug, but when i thought about it. it is harder to fix than you think.

firstly evince is not toem. here user interaction is necessary all the time when document is scrolled, so everytime toolbar appearing and disappearing is not a good idea.

 i think with gnome 2.28 the toolbar design has been improved to make it more compact and this is a good first step.

maybe we can extend this so that in fullscreen it vanishes completely and only a line or soemthing is shown, which when clicked revealed the complete toolbar or something.
Comment 11 Tony Freeman 2009-12-18 14:26:01 UTC
I like this idea.

An example would be the way gedit handles fullscreen.  I've gotten busy with work so I've not had the complete concentration I need to dive into this myself.
Comment 12 Praveen Thirukonda 2009-12-23 12:12:21 UTC
(In reply to comment #11)
> I like this idea.
> 
> An example would be the way gedit handles fullscreen. 

gedit's implementation does indeed look nice. though it should come with a pin option or something in the toolbar/settings so that people who want it to be always there can do so.

maybe some clever hacker can copy gedit's code to evince.
Comment 13 Fabio Durán Verdugo 2011-05-18 04:17:02 UTC
Does this report is still active?
Comment 14 Wouter Bolsterlee (uws) 2011-05-18 18:46:23 UTC
This bug report is not addressed in Evince 2.30.x (toolbar stays visible in full-screen mode).
Comment 15 Helder 2012-06-22 13:16:07 UTC
Still happening on evince 3.4.0 (Ubuntu 12.04).
Comment 16 Germán Poo-Caamaño 2012-10-26 00:31:25 UTC
*** Bug 656814 has been marked as a duplicate of this bug. ***
Comment 17 Carlos Garcia Campos 2012-10-26 08:59:50 UTC
I've implemented this recently as part of the wip UI modernization in this branch:

http://git.gnome.org/browse/evince/log/?h=gnome3-style

See:

http://git.gnome.org/browse/evince/commit/?h=gnome3-style&id=8bffb3baf322f653d1f2b06fef5e04460e6d3b24
Comment 18 Carlos Garcia Campos 2013-01-05 12:25:22 UTC
gnome3-style branch has already been merged into master, so this is now fixed.