GNOME Bugzilla – Bug 492900
[PATCH] Support for password protected podcasts
Last modified: 2020-03-17 09:05:11 UTC
The attached patch allows users to subscribe to password protected podcasts (HTTP basic authentication only). It still needs some work on the following items: - database schema evolution, that creates the username and password text columns in the database - the password Entry widgets have visibility set to true due to a possible bug in Gtk# 2.10 where Entry.Text, if visibility is false, is always empty
Created attachment 98425 [details] [review] patch for http basic authentication in podcast subscription
Thanks, will look this over Monday.
I'm not crazy about the idea of user credentials being stored in the db as cleartext, could this be reworked to use the GNOME Keyring?
Actually yes. Give me a couple of days and I'll submit a new patch with Gnome keyring support.
Neat, thanks! Seeing how DBs are passed around on here and on the list I'd rather not see anyone post their passwords.
Created attachment 98986 [details] [review] patch for http authentication, with gnome-keyring support
Whoops, sorry for the long turn around, I just saw this.
The patch doesn't apply to the current codebase.
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address. It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Celso, could you adapt your patch to a recent version of Banshee? Sorry it took awhile, I promise to review it promptly.
*** Bug 612365 has been marked as a duplicate of this bug. ***
hello, I try to adapt the oldest ticket patch but the issue is that migo do not support credential for moment. Can I modify migo code because it seems to be an external lib?
Created attachment 172113 [details] [review] partial patch I have create a patch for current version but it miss the use of credential in request because migo currently do not allowed that.
Migo is structured as a library, but it's included in the Banshee source, in src/Libraries/Migo/ So feel free to include any modifications necessary in your patch. I'm not sure about the dependency on gnome-keyring-sharp : would that work on non-Linux platforms (OSX/Windows) ? Maybe it should e an optional dependency ?
the issue is that, if we do not store it in gnome keyring we have to store that elsewere and the simple is to store it over database. So I think best is to modify DB structure to add username and password field. and remove gnome keyring dependency.
Created attachment 172129 [details] [review] 2cd patch I do not know podcast with login pass. if someone can test it and make feedback. you must apply previous patch first and this one in second.
Sticking the username and password in the db is definitely not the ideal solution. We need to come up with some abstraction for private information.
There is an open source, multi platform .Net/Mono library for interacting with keyrings. If the Windows port of Banshee is holding up integration of password support for podcasts, this might be a solution: http://keystorage.codeplex.com/ http://en.wikipedia.org/wiki/Data_Protection_API http://en.wikipedia.org/wiki/DPAPI Taking a step back: where do the other parts of Banshee that use passwords keep that data?
*** Bug 649387 has been marked as a duplicate of this bug. ***
*** Bug 679833 has been marked as a duplicate of this bug. ***
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.