The desktop icon placement places icons under the panel.  That is bad.  GMC does
it, but it certainly doesn't make it right.



------- Additional Comments From darin@bentspoon.com 2000-06-28 15:49:31 ----

I don't know how to discover what parts of the desktop are covered. The 1-day
estimate may be unreasonably optimistic.



------- Additional Comments From gzr@eazel.com 2000-08-22 09:54:08 ----

You are right.  It seems the only way to do this is to add some sort of CORBA 
call to the panel to get it's bounds and position. Then we would have to 
iterate through all launched panels.



------- Additional Comments From darin@bentspoon.com 2000-09-12 10:18:33 ----

We should do this, or decide not to do this, right away.



------- Additional Comments From linuxfan@ionet.net 2000-09-21 08:41:29 ----

*** Bug 43222 has been marked as a duplicate of this bug. ***



------- Additional Comments From eli@eazel.com 2000-10-16 19:38:11 ----

Batch-assigning QA ownership of remaining bugs to eli@eazel.com



------- Additional Comments From snickell@stanford.edu 2000-11-04 15:42:00 ----

gmc seems to handle this, it might be worth trying to figure out what GMC does.
Also Window Managers are supposed to be aware of panel position, so the hooks
are already provided in *some* manner.



------- Additional Comments From jsh@pixelslut.com 2000-11-09 11:52:17 ----

Window managers find the position of windows that shouldn't be covered by
checking for the WIN_HINTS_DO_NOT_COVER bit of the _WIN_HINTS property on each
window



------- Additional Comments From bneely@parts-unknown.com 2001-01-27 13:34:50 ----

*** Bug 46072 has been marked as a duplicate of this bug. ***



------- Additional Comments From eli@eazel.com 2001-02-09 11:28:41 ----

Duane is now the proud owner for Desktop QA.



------- Additional Comments From duane@eazel.com 2001-02-20 10:14:31 ----

*** Bug 46759 has been marked as a duplicate of this bug. ***



------- Additional Comments From duane@eazel.com 2001-02-20 11:40:07 ----

*** Bug 46780 has been marked as a duplicate of this bug. ***



------- Additional Comments From darin@bentspoon.com 2001-03-05 07:51:21 ----

*** Bug 47342 has been marked as a duplicate of this bug. ***



------- Additional Comments From don@eazel.com 2001-03-11 16:02:34 ----

Maciej and George are working on a possible patch for this in 1.0.




------- Additional Comments From jirka@5z.com 2001-03-11 23:03:02 ----

Created an attachment (id=1398)
a patch for this




------- Additional Comments From jirka@5z.com 2001-03-11 23:06:39 ----

The patch above makes this work, hopefully without any unintended side effects.
 What it does is make the scrolled area origin be offset by the amount of the
panel area.  It does not move icons near the bottom of the screen back into the
visible desktop and they can go offscreen then however, but the current code
doesn't do much for this case either apparently.  However when doing cleanup it
will avoid the panels.  This only works if you get the most current panel from
CVS however as it depends on a change in the panel I just comitted this afternoon.



------- Additional Comments From don@eazel.com 2001-03-12 07:25:57 ----

Let's get as many people as possible reviewing this patch ASAP.




------- Additional Comments From darin@bentspoon.com 2001-03-12 11:05:27 ----

I would call this function "set_margins" rather than "setup_icon_offsets".



------- Additional Comments From gzr@eazel.com 2001-03-12 11:07:28 ----

I am seeing cases where the code is behaving oddly when the desktop is placing 
newly created folders. Also, drags occasionally place icons in an odd 
location.  I can debug further after I look at my more pressing 1.0 bugs.



------- Additional Comments From sullivan@eazel.com 2001-03-12 13:33:40 ----

George: What will happen if you don't have the latest panel code?



------- Additional Comments From jirka@5z.com 2001-03-12 17:45:51 ----

It just ignores the panel if you don't have the latest one, that is, it assumes
the offsets (margins as darin better put it) are 0 if the property is not set. 
So the behaviour is the same as it was before in the case you have an old panel.



------- Additional Comments From jacob@ximian.com 2001-03-15 08:57:23 ----

i've been trying this patch out, and it is working out pretty well so far.



------- Additional Comments From eli@eazel.com 2001-03-26 11:20:10 ----

SPAAAAAAAAAM! 

(Jon Allen has taken these components; QA Assigning bugs to him.)



------- Additional Comments From jirka@5z.com 2001-03-27 00:36:32 ----

What's the status of this bug ... should the patch be applied?



------- Additional Comments From jirka@5z.com 2001-03-27 18:55:43 ----

Applied to HEAD



------- Additional Comments From eli@eazel.com 2001-04-26 15:03:57 ----

Stealing verification.



------- Additional Comments From eli@eazel.com 2001-04-26 15:04:27 ----

[Note to self: also check "Clean Up By Name" case from bug #46780 when verifying
this.]



------- Additional Comments From eli@eazel.com 2001-04-26 15:06:47 ----

All duplicates verified; now checking this bug.



------- Additional Comments From eli@eazel.com 2001-04-27 15:14:41 ----

After rebuilding Nautilus and gnome-core (both CVS HEAD), Nautilus still appears
to be placing desktop icons underneath the GNOME Panel.

Does one need to do anything else special to make this work? 



------- Additional Comments From jirka@5z.com 2001-04-30 08:43:33 ----

Hmm weird.  Let's just make sure we are talking about the same thing.  Even with
this patch nautilus will still place icons under the lower panel if their
positions are too large.  What the panel does is two things:

1) Move the origin, so that if the panel is on top or left the icons are moved
out of the way
2) When cleaning up icons / relaying them out it avoids all panels, even bottom ones

But if you had an icon that was in a lower right corder and you add a panel
there, the icon won't move.  I suppose some sort of better dynamic "flowing" of
the icons around panels is a wholly another bug and I think it would require
some serious thinking about how to design the UI.



------- Additional Comments From jirka@5z.com 2001-04-30 08:45:05 ----

I wanted to also say, I've tested it with the newest HEAD panel and nautilus and
it works for me, I missed that sentence in the last comment.



------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 20:33 -------

The original reporter (linuxfan@ionet.net) of this bug does not have an account here.
Reassigning to the exporter, unknown@bugzilla.gnome.org.