GNOME Bugzilla – Bug 407539
ATK missing ATK_STATE_HAS_TOOL_TIP which at-spi has
Last modified: 2014-10-22 11:23:47 UTC
self-explanatory - at-spi has STATE_HAS_TOOLTIP but ATK doesn't have equivalent state.
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 . PLEASE NOTE: If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla. Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Created attachment 289059 [details] [review] Proposed patch The AT-SPI2 state is ATSPI_STATE_HAS_TOOLTIP (with 'tooltip' as one word) [1] so I followed that for consistency's sake. [1] https://developer.gnome.org/libatspi/2.14/libatspi-atspi-constants.html#AtspiStateType
Review of attachment 289059 [details] [review]: Looks good. Just make a small change and commit it in any case. ::: atk/atkstate.h @@ +125,3 @@ * that activation renders conditional content. Note that ordinary * tooltips are not considered popups in this context. @Since: ATK-2.12 + *@ATK_STATE_HAS_TOOLTIP: Indicates this object has a tooltip. @Since: ATK-2.15.1 To make it easier, we put the Since with the stable release that will include this change. So as we mentioned on IRC, please use 2-16 there.
Comment on attachment 289059 [details] [review] Proposed patch Committed with the change specified. Thanks for the review! https://git.gnome.org/browse/atk/commit/?id=c56ca79