GNOME Bugzilla – Bug 738982
Add support for ATK_STATE_HAS_TOOLTIP
Last modified: 2014-10-23 16:33:24 UTC
Created attachment 289100 [details] [review] proposed patch (note: still needs ATK version check or minimum-version bump) We should have ATK_STATE_HAS_TOOLTIP soon (see bug 407539). Once we do, Gtk+ should support it. The attached patch here works with the attached patch on bug 407539 and can be tested via assistive technologies if you also have the patch attached to bug 738953. It includes a new test. It does not include an ATK version check or minimum-version bump. I'll fix that, along with any other needed changes, once the new state is in a released version of ATK.
Review of attachment 289100 [details] [review]: looks good to me; if we have that state in 3.14 already, we should cherry-pick this on the gtk-3-14 branch as well
As I see you discovered yesterday, this state is not in ATK 2.14. It's new API. Related to that, it's only just now added to ATK master. As I mentioned in the opening report: > The attached patch [...] does not include an ATK version check or > minimum-version bump. I'll fix that, along with any other needed changes, once > the new state is in a released version of ATK. My plan was to wait for Piñeiro to roll a release of ATK that included it, and then provide you with a new patch that had that check/bump. Since you committed the patch as-is, are you planning on adding that change to Gtk+ yourself after there is a new ATK release?
yeah, we'll add the version check when the version exists, and when somebody complains