After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 392424 - GNOME_DOC_INIT and not-found gdu
GNOME_DOC_INIT and not-found gdu
Status: RESOLVED FIXED
Product: gnome-doc-utils
Classification: Deprecated
Component: build utils
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-doc-utils maintainers
gnome-doc-utils maintainers
: 350441 (view as bug list)
Depends on:
Blocks: 354101 392411 394050
 
 
Reported: 2007-01-03 19:01 UTC by Christian Persch
Modified: 2007-01-25 21:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.53 KB, patch)
2007-01-03 19:40 UTC, Christian Persch 		none Details | Review
revised patch (1.41 KB, patch)
2007-01-16 23:48 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2007-01-03 19:01:00 UTC 
GNOME_DOC_INIT aborts when it can't find gnome-doc-utils. However, programmes may want to conditionally support gdu only when it's present. For this, GNOME_DOC_INIT should support optional 2nd and 3rd arguments ACTION-IF-FOUND and ACTION-IF-NOT-FOUND, like most stock autoconf macros do.
Comment 1 Christian Persch 2007-01-03 19:40:30 UTC 
Created attachment 79302 [details] [review]
proposed patch

This patch adds

GNOME_DOC_CHECK ([MINIMUM-VERSION],[ACTION-IF-FOUND],[ACTION-IF-NOT-FOUND])
Comment 2 Shaun McCance 2007-01-15 23:27:44 UTC 
We can't just drop GNOME_DOC_INIT, for compatibility reasons.  I'd be OK with doing this otherwise.
Comment 3 Christian Persch 2007-01-15 23:50:37 UTC 
That's exactly why the patch does *not* remove GNOME_DOC_INIT.
Comment 4 Shaun McCance 2007-01-16 01:15:05 UTC 
Sorry, I missed the part at the bottom of the patch.  This is fine by me, but we should also add some code to gnome-autogen.sh to check for GNOME_DOC_CHECK as well as GNOME_DOC_INIT.
Comment 5 Christian Persch 2007-01-16 23:46:40 UTC 
Hmm I hadn't thought about gnome-autogen... 
I named the macro GNOME_DOC_CHECK because INIT seems a bit odd for a macro that doesn't necessarily initialise anything (if it's not found), but it's probably better than changing autogen. So probably just renaming GNOME_DOC_CHECK to INIT and removing the stub at the end will do the trick.
Comment 6 Christian Persch 2007-01-16 23:48:53 UTC 
Created attachment 80440 [details] [review]
revised patch

This just adds optional 2nd and 3rd arguments to GNOME_DOC_INIT.
Comment 7 Christian Persch 2007-01-25 18:03:28 UTC 
        * tools/gnome-doc-utils.m4:
        - Provide a 3-argument variant of GNOME_DOC_INIT, to use if you don't
        want missing gdu be fatal. Bug #392424, also fixes bug #350441.
Comment 8 Christian Persch 2007-01-25 18:04:02 UTC 
*** Bug 350441 has been marked as a duplicate of this bug. ***