After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354101 - must not conditionally use GNOME_DOC_INIT
must not conditionally use GNOME_DOC_INIT
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on: 392424
Blocks:
 
 
Reported: 2006-09-03 11:44 UTC by Christian Persch
Modified: 2007-02-02 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
restore the check (using gdu 0.9.0) (1.70 KB, patch)
2007-01-29 17:55 UTC, Christian Persch 		none Details | Review
the right patch (1.70 KB, patch)
2007-01-29 17:56 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2006-09-03 11:44:57 UTC 
http://cvs.gnome.org/bonsai/cvsquery.cgi?branch=&dir=gucharmap&who=behdad&date=explicit&mindate=2006-09-02%2019:59&maxdate=2006-09-02%2020:01
(from bug 332880)

GNOME_DOC_INIT uses AM_CONDITIONAL, and therefore must not be used conditionally.
Comment 1 Behdad Esfahbod 2006-09-03 16:48:47 UTC 
Ah.  How should one do that then?
Comment 2 Christian Persch 2006-09-03 17:14:56 UTC 
I guess the only possibility would be for GNOME_DOC_INIT should take additional parameters, like so:
GNOME_DOC_INIT([VERSION],[ACTION-IF-FOUND],[ACTION-IF-NOT-FOUND])
Comment 3 Behdad Esfahbod 2006-09-03 20:45:50 UTC 
And the macro doesn't seem to accept anything like that :(.   Reverting.

2006-09-03  Behdad Esfahbod  <behdad@gnome.org>

        Bug 354101 – must not conditionally use GNOME_DOC_INIT

        * configure.ac: Rever the last change...
Comment 4 Christian Persch 2006-09-03 20:51:57 UTC 
(In reply to comment #3)
> And the macro doesn't seem to accept anything like that :(.   Reverting.

Yes. What I meant was to file a bug on gdu for this :)
Comment 5 Christian Persch 2007-01-29 17:55:35 UTC 
Created attachment 81451 [details] [review]
restore the check (using gdu 0.9.0)
Comment 6 Christian Persch 2007-01-29 17:56:00 UTC 
Created attachment 81452 [details] [review]
the right patch
Comment 7 Behdad Esfahbod 2007-01-29 20:49:17 UTC 
Thanks Christian.  Feel free to commit.
Comment 8 Christian Persch 2007-02-02 13:20:30 UTC 
        * Makefile.am:
        * configure.ac: Don't use GNOME_DOC_INIT conditionally. Update gdu
        dependency to 0.9.0. Bug #354101.