GNOME Bugzilla – Bug 392411
can't conditionally call GNOME_DOC_INIT
Last modified: 2007-02-17 13:52:06 UTC
From configure.in: dnl ================================================================ dnl GNOME User Manual (requires gnome-doc-utils) dnl ================================================================ AC_ARG_ENABLE(user_manual, [ --enable-user-manual Build GNOME user manual], enable_user_manual=yes, enable_user_manual=no) if test x"$enable_user_manual" = "xyes"; then GNOME_DOC_INIT [...] That doesn't work, since GNOME_DOC_INIT uses AM_CONDITIONAL which must not be called conditionally.
Created attachment 81222 [details] [review] proposed patch
hey, thanks Just one issue though, we now think it would be better if the docs building is enabled by default (since no-one is actually building and reading the user manual, including the Ubuntu package maintainers). Would it be possible if you could remove the AC_ARG_ENABLE macro? All we need is for GNOME_DOC_INIT to fail gracefully if gnome-doc-utils is not found.
Created attachment 81231 [details] [review] alternative patch This patch removes the --enable-user-manual option.
*** Bug 402416 has been marked as a duplicate of this bug. ***
Created attachment 81593 [details] [review] simplified patch
I hit this problem as well. Can someone apply the patch from comment #5? | $ ./autogen.sh --prefix /opt/gnome-2-18 --disable-static --enable-gtk-doc | [large chunks left out] | configure: error: conditional "HAVE_GNOME_DOC_UTILS" was never defined. | Usually this means the macro was only invoked conditionally.
This patch depends on the latest version of gnome-doc-utils, which we thought was not released yet. Thanks for reminding us though, as it looks like a new version was released on the 2007-01-29. So we should certainly apply the patch then. Tristan, can I apply the patch?
Sure, go ahead Vincent or Christian ...
* Makefile.am: * configure.ac: Call GNOME_DOC_INIT unconditionally. Bug #392411.
Just for the record (and since alot was said and I dont remember clearly)... this patch doesnt require anybody to have g-d-u right ? If I dont have g-d-u installed, I should not be forced to know about some kind of --disable-g-d-u argument, it should just kindly say "didnt find g-d-u, dont really care, moving on and building glade...". Can you just confirm that for me one last time ?
chpe, it's broken now: Makefile.am:3: HAVE_GNOME_DOC_UTILS does not appear in AM_CONDITIONAL
Are you sure you have gdu >= 0.9.0 ?
For sure not. But shouldn't gnome-autogen.sh check for them? Well, let's close this, we have enough work to do.
I see the problem. configure checks for 0.9.0, but autogen fails before that, because of the incompatibility. I added the required version to autogen. * autogen.sh: Set the required gdu version in autogen too. Bug #392411.