GNOME Bugzilla – Bug 360237
Trash does not show deleted messages, results in broken inbox, crashes application.
Last modified: 2013-09-10 14:04:39 UTC
Clicking the Trash mailbox does not display any messages, despite the window title reporting "Trash ([x] deleted)" where [x] is the correct number of messages. Instead the message list is completely empty. After viewing the trash and returning to the inbox, an error message is displayed (see below). After closing this error message, the inbox also now displays an empty message list. This continues to happen for the inbox for that particular account until evolution is closed. The error message: Error while Generating message list. Error executing search expression: Unknown type in parse tree: 140585792: (and (match-all (and (not (system-flag "deleted")) (not (system-flag "junk")))) ) End error message. Evolution will then crash if "Hide deleted messages" is enabled or disabled (it does not matter which). It also seems to crash if this option is enabled or disabled before triggering the above bug (i.e. the user has not closed Evolution since changing that option). I have a total of four stack traces for this bug, each generated from Bug Buddy after triggering the crash in slightly different ways. I will attach them all in a moment.
Created attachment 74169 [details] Stack trace 1 This stack trace was generated by viewing the trash, then viewing the inbox, closing the error message window and then disabling "Hide deleted messages" from the View menu.
Created attachment 74170 [details] Stack trace 2 This stack trace was generated when viewing the Trash while a new message was being filtered. As soon as the message was done being filtered evo crashed. I had not yet viewed the inbox (or any other folders).
Created attachment 74171 [details] Stack trace 3 This was the same as trace 1, but enabling "Hide deleted messages" instead of disabling it.
Created attachment 74173 [details] Stack trace 4 This was generated by first enabling "Hide deleted messages", then viewing the trash, then viewing the inbox. If I remember correctly, evo crashed as soon as the error window was closed.
i have a strange feeling that we might have many, many duplicates of this one here. srini: poke?
Created attachment 74186 [details] [review] Revert part of latest commit in mail/em-folder-brower.c This patch reverts the problematic part of the latest commit to em-folder-browser.c. I have no idea what this does or what it fixes, but it makes the trashfolder problem go away. This patch is not intended as a fix, more as a pointer to the problem.
Seems like a search bug in my last commit. Ill look into it.
Hmm Got it. It tries to save the state for Trash which is a vfolder and doesnt seem to have settings for it. Ill put up a patch for it soon.
Just did a quick look into it. Seems to have the same issue for junk folder too. The save/retrieve search for both seem to have some issue
Created attachment 74229 [details] [review] Tryout patch
Can you try this? This should be the main cause. Just the last hunk of this patch should fix and the other two are for some other issues. Im yet to verify the fix on other complicated scenarios.
I can confirm this patch works. The error message on viewing inbox after trash about the bad search filter is gone, the crash after entering a searchfilter in the trashfolder is also gone and the contents of the trashfolder are shown correctly now.
Thx Jan. Ill close on this. soon. The final patch might look little different. Ill fix and upload sometime this week.
Pasting some part of stacktrace 4, omitting some libc foo. Also removing some string noise.
+ Trace 75598
Srini, I believe bug 359785 and its 6 duplicates to be the very same crash. Andre, got the same feeling. Most likely a lot of the recent useless stacktraces, closed INCOMPLETE, actually are duplicates too.
*** Bug 359785 has been marked as a duplicate of this bug. ***
*** Bug 361060 has been marked as a duplicate of this bug. ***
*** Bug 361112 has been marked as a duplicate of this bug. ***
*** Bug 359931 has been marked as a duplicate of this bug. ***
*** Bug 359830 has been marked as a duplicate of this bug. ***
*** Bug 359957 has been marked as a duplicate of this bug. ***
if bug #359957 is really a dupe of this one, this has nothing to do with IMAP as I use POP3 exclusively and never used IMAP4. So the bug title should be changed (-"[IMAP] ")
Guenther, The attached patch should fix the problem as said in comment #12 . Im looking into few more scenarios. Ill get this in asap.
i can reproduce this with local folders, right.
*** Bug 361160 has been marked as a duplicate of this bug. ***
I marked 361160 as duplicated of this one, but I'm able to reproduce with the Junk folder instead of Trash. An stack trace is attached in that bug, if it helps.
*** Bug 359774 has been marked as a duplicate of this bug. ***
*** Bug 361185 has been marked as a duplicate of this bug. ***
(In reply to comment #23) > Guenther, The attached patch should fix the problem as said in comment #12 . Im > looking into few more scenarios. Ill get this in asap. Srini, I never doubted that. :) I merely poked you to have a close look at the duplicates and the really different stacktraces attached to this bug. Anyway, comment 22 and comment 24 kind of already took care about that. Thanks Stephane for caring and pointing this out.
ok :) I got it. This isnt specific to any provider. It can happen on any folder to be frank (junk, trash, etc)
*** Bug 360284 has been marked as a duplicate of this bug. ***
Although slightly different (notably the emfb_search_search_activated() call), I believe bug 360284 to be yet another duplicate of this very crash...
*** Bug 361302 has been marked as a duplicate of this bug. ***
Fixed to 2.8
*** Bug 360501 has been marked as a duplicate of this bug. ***
*** Bug 360308 has been marked as a duplicate of this bug. ***
*** Bug 359678 has been marked as a duplicate of this bug. ***
*** Bug 361344 has been marked as a duplicate of this bug. ***
*** Bug 360238 has been marked as a duplicate of this bug. ***
*** Bug 361831 has been marked as a duplicate of this bug. ***
GAR. Srini, would you please have a second look at this patch and the one committed to fix bug 359236? This one got both... Although I am pleased to see these nasty and often reported crashes being fixed, I wonder, how you could commit both. Also, you just messed with my clean track of duplicates. ;) Seriously, thanks for fixing these little buggers, Sini. :) This will cut down on the flood of useless stacktraces.
Guenther, I didnt get you. Im sure these patches fixes the bug.
Uhm. I noticed one more problem. Bug 361831 <- this duplication bug. I repoted that then i noticed that in this bug there is a patch for it. Nah, i applied this patch to my 2.8.1 evolution and segfaults and dialog errors disappeared. But seems that Trash does not operates full correctly. I mean a simple example: I got 10 mail. I delete 3 mail. Those are in Trash now. I can see them. I quit evolution and start it again. I got to Trash, and i see only 1 message. After clicking to inbox and other dirs and click back to Trash i see ALL 3 mail again. :S This is intresting and dunno what cause this. Any idea about ? Regards Christian Hamar alias krix Hungary
I dont think this has anything to do with Search fixes or implementation. Any similiar observations? Im puzzled. I doubt this may be something to do with the folder yet to be opened. Mail hackers may have an answer for it.
*** Bug 362716 has been marked as a duplicate of this bug. ***
*** Bug 361414 has been marked as a duplicate of this bug. ***
*** Bug 361474 has been marked as a duplicate of this bug. ***
*** Bug 361782 has been marked as a duplicate of this bug. ***
*** Bug 361307 has been marked as a duplicate of this bug. ***
*** Bug 360097 has been marked as a duplicate of this bug. ***
*** Bug 360122 has been marked as a duplicate of this bug. ***
*** Bug 367560 has been marked as a duplicate of this bug. ***
*** Bug 377761 has been marked as a duplicate of this bug. ***
*** Bug 384866 has been marked as a duplicate of this bug. ***
*** Bug 369496 has been marked as a duplicate of this bug. ***
*** Bug 388049 has been marked as a duplicate of this bug. ***
*** Bug 384865 has been marked as a duplicate of this bug. ***
*** Bug 471855 has been marked as a duplicate of this bug. ***