GNOME Bugzilla – Bug 339217
add translator comments to cal-prefs-dialog.glade
Last modified: 2006-06-14 11:20:14 UTC
in calendar/gui/dialogs/cal-prefs-dialog.glade, we have several strings like _Mon _Tue _Wed T_hu _Fri _Sat S_un we should add translator comments by adding "comments="Monday"" to the tag (see bug 155294 for more info how to do). i know that it seems obvious what the strings mean, but i remember having translators who did not know what "RSVP" meant and therefore did not translate it - let's be on the safe side.
Created attachment 67244 [details] [review] Adding translator comments to cal-prefs-dialog.glade
hi aish, please only add comments for the seven abbreviated week days, the other stuff is pretty clear. adding "this label indicates the time zone" to the label string "Time _zone:" is unuseful clutter that does not contain any additional information - sorry...
Comment on attachment 67244 [details] [review] Adding translator comments to cal-prefs-dialog.glade Index: ChangeLog =================================================================== RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v retrieving revision 1.3053 diff -u -p -r1.3053 ChangeLog --- ChangeLog 8 Jun 2006 19:23:13 -0000 1.3053 +++ ChangeLog 13 Jun 2006 10:00:13 -0000 @@ -1,3 +1,8 @@ +2006-06-13 Aishwarya k <aishkalyan@gmail.com> + + *Fix for bug #339217 + */gui/dialogs/cal-prefs-dialog.glade : Added translator comments for weekdays + Index: cal-prefs-dialog.glade =================================================================== RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/cal-prefs-dialog.glade,v retrieving revision 1.37 diff -u -p -r1.37 cal-prefs-dialog.glade --- cal-prefs-dialog.glade 5 Jun 2006 09:38:20 -0000 1.37 +++ cal-prefs-dialog.glade 13 Jun 2006 10:00:58 -0000 @@ -469,7 +469,7 @@ <widget class="GtkCheckButton" id="mon_button"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">_Mon</property> + <property name="label" translatable="yes" comments="Monday">_Mon</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -477,7 +477,7 @@ <property name="inconsistent">False</property> <property name="draw_indicator">True</property> <accessibility> - <atkproperty name="AtkObject::accessible_name" translatable="yes">Monday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Monday">Monday</atkproperty> </accessibility> </widget> <packing> @@ -491,7 +491,7 @@ <widget class="GtkCheckButton" id="tue_button"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">_Tue</property> + <property name="label" translatable="yes" comments="Tuesday">_Tue</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -499,7 +499,7 @@ <property name="inconsistent">False</property> <property name="draw_indicator">True</property> <accessibility> - <atkproperty name="AtkObject::accessible_name" translatable="yes">Tuesday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Tuesday">Tuesday</atkproperty> </accessibility> </widget> <packing> @@ -513,7 +513,7 @@ <widget class="GtkCheckButton" id="wed_button"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">_Wed</property> + <property name="label" translatable="yes" comments="Wednesday">_Wed</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -521,7 +521,7 @@ <property name="inconsistent">False</property> <property name="draw_indicator">True</property> <accessibility> - <atkproperty name="AtkObject::accessible_name" translatable="yes">Wednesday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Wednesday">Wednesday</atkproperty> </accessibility> </widget> <packing> @@ -535,7 +535,7 @@ <widget class="GtkCheckButton" id="thu_button"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">T_hu</property> + <property name="label" translatable="yes" comments="Thursday">T_hu</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -543,7 +543,7 @@ <property name="inconsistent">False</property> <property name="draw_indicator">True</property> <accessibility> - <atkproperty name="AtkObject::accessible_name" translatable="yes">Thursday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Thursday">Thursday</atkproperty> </accessibility> </widget> <packing> @@ -557,7 +557,7 @@ <widget class="GtkCheckButton" id="fri_button"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">_Fri</property> + <property name="label" translatable="yes" comments="Friday">_Fri</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -565,7 +565,7 @@ <property name="inconsistent">False</property> <property name="draw_indicator">True</property> <accessibility> - <atkproperty name="AtkObject::accessible_name" translatable="yes">Friday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Friday">Friday</atkproperty> </accessibility> </widget> <packing> @@ -579,7 +579,7 @@ <widget class="GtkCheckButton" id="sat_button"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">_Sat</property> + <property name="label" translatable="yes" comments="Saturday">_Sat</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -587,7 +587,7 @@ <property name="inconsistent">False</property> <property name="draw_indicator">True</property> <accessibility> - <atkproperty name="AtkObject::accessible_name" translatable="yes">Saturday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Saturday">Saturday</atkproperty> </accessibility> </widget> <packing> @@ -601,7 +601,7 @@ <widget class="GtkCheckButton" id="sun_button"> <property name="visible">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">S_un</property> + <property name="label" translatable="yes" comments="Sunday">S_un</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -609,7 +609,7 @@ <property name="inconsistent">False</property> <property name="draw_indicator">True</property> <accessibility> - <atkproperty name="AtkObject::accessible_name" translatable="yes">Sunday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Sunday">Sunday</atkproperty> </accessibility> </widget> <packing>
Created attachment 67249 [details] [review] Adding translator comments to cal-prefs-dialog.glade
please only add the comments to the *abbreviated* week days, not to the rest of them. adding "comments="Saturday"" to the string "Saturday" does not supply any additional information for the translator and is not needed - translating "saturday" to another language is pretty clear, while translating "Sat" is not, that's why you should add translator comments. for future reference, please also make sure that you do not change whitespaces and stuff like that, for example in the line - <atkproperty name="AtkObject::accessible_name" translatable="yes">Monday</atkproperty> + <atkproperty name="AtkObject::accessible_name" translatable="yes" comments="Monday">Monday</atkproperty> you removed one whitespace at the beginning. please do not do that. anyway, just wrote the latter one for future reference.
Created attachment 67317 [details] [review] Final Patch
i've committed the patch both to stable branch and HEAD: http://cvs.gnome.org/viewcvs/evolution/calendar/gui/dialogs/cal-prefs-dialog.glade?r1=1.36.2.1&r2=1.36.2.2 http://cvs.gnome.org/viewcvs/evolution/calendar/gui/dialogs/cal-prefs-dialog.glade?r1=1.37&r2=1.38 the fix will be included in stable evolution 2.6.3 and unstable evolution 2.7.4. thanks a lot.