After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338913 - Terminal resized when switching tabs
Terminal resized when switching tabs
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: High major
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
: 340127 342253 368349 374942 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-04-18 16:58 UTC by Behdad Esfahbod
Modified: 2009-07-22 10:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Behdad Esfahbod 2006-04-18 16:58:04 UTC
Moving discussion from bug 336325 here.  This may be a regression after committing the patch in that bug.

I reproduced it according to these instructions:

Quoting Egmont Koblinger:

I have no straightforward way to reproduce it, but it occurs very often.
Launch gnome-terminal, open three tabs (Ctrl+Alt+T twice), make the window a
little bit larger, click on every tab, and if it isn't buggy yet then repeat
these: create one more tab, click on them, make the window slightly bigger,
click on the tabs again and so on...
Comment 1 Egmont Koblinger 2006-04-18 17:33:38 UTC
I tried but could not reproduce it without that certain patch.
Comment 2 Dennis Cranston 2006-04-24 04:51:20 UTC
After I reverted the patch applied in bug 336325 (http://bugzilla.gnome.org/attachment.cgi?id=62506), the terminal does not resize when switching between tabs.
Comment 3 Behdad Esfahbod 2006-04-29 17:21:35 UTC
*** Bug 340127 has been marked as a duplicate of this bug. ***
Comment 4 Behdad Esfahbod 2006-05-18 23:29:29 UTC
*** Bug 342253 has been marked as a duplicate of this bug. ***
Comment 5 Dan Williams 2006-05-19 02:26:17 UTC
Any action on this?  Shows up for me every time with gt-2.15.0 on Fedora Rawhide.

a) open 3 tabs
b) Alt+2 to switch to tab #2
c) Alt+1 to switch to tab #1, terminal maximizes _horizontally_
d) Alt+2 to switch to tab #2 again
e) Alt+1 to switch to tab #1 again, terminal now maximizes _vertically_

Also maximizes when I press Alt+Shift+T to open a new tab.  Every time.  (The sound you hear is me reverting #336325 in Fedora packages :)
Comment 6 Matthias Clasen 2006-05-19 14:59:30 UTC
Maybe it would help to investigate which alleged GTK+ bug the dropped
hack was working around...
Comment 7 Behdad Esfahbod 2006-05-19 17:10:24 UTC
I really have no clue about size allocations and such...  Somebody with a knowledge of that should debug it.  Nalin or Owen may have some vague memory too...
Comment 8 Eric Anderson 2006-05-25 17:48:11 UTC
I was able to reproduce the problem as well. I thought that my patch for bug 95316 might also fix this bug as well, so I applied that patch to CVS and it does fix the resizing. Two birds with one stone :)
Comment 9 Behdad Esfahbod 2006-05-25 19:50:30 UTC
I confirm your patch fixes the two bugs for me.   Bug 324426 remains though.  Can you look into that one too?
Comment 10 Eric Anderson 2006-05-25 19:57:17 UTC
That was the first one I looked at and made a patch for. So I already submitted a patch...
Comment 11 Adam Williamson 2006-07-03 16:44:38 UTC
Seeing this bug very badly in GNOME 2.15 in Mandriva Cooker. I start my terminal window at size 80x24, by the time I've opened a few tabs and shifted about a few times, it's 80x43 and hitting the bottom of the screen. Is this going to be resolved soon? Thanks!
Comment 12 Adam Williamson 2006-07-03 16:46:18 UTC
Seeing this bug very badly in GNOME 2.15 in Mandriva Cooker. I start my terminal window at size 80x24, by the time I've opened a few tabs and shifted about a few times, it's 80x43 and hitting the bottom of the screen. Is this going to be resolved soon? Thanks!

One interesting thing I notice is that, on the tabs which cause the growth to happen, the reported size of the window is wrong. Let's say I start the window at size 80x24 and open a few tabs. I switch to one and the window grows by several lines. However, the reported size - when you click and hold on a corner of the window, to resize it - still says 80x24. If I then switch back to an empty tab, which doesn't cause the window to grow further, and look at the reported size, it is correct: 80x34.
Comment 13 Adam Williamson 2006-07-03 16:46:56 UTC
Sorry for the duped comment, bugzilla was responding very slowly.
Comment 14 Egmont Koblinger 2006-07-06 16:50:42 UTC
For me it seems that Eric's patch (bug 342968, third comment) fixes all these resize issues, even bug 324426. Thanks Eric, nice work!
Comment 15 Mitch 2006-08-01 17:36:50 UTC
note this problem (random resizing on tab switching) is still happening with gnome-terminal 2.15.4
Comment 16 Wouter Bolsterlee (uws) 2006-08-10 09:01:53 UTC
This might be the same issue as filed in bug #348601. Not marking duplicate since I'm not sure. Note that bug #348601 has several comments that might be worthwile to read for someone looking into this issue.
Comment 17 Dennis Cranston 2006-09-06 05:22:23 UTC
I am still getting bit by this bug in GNOME 2.16.
Comment 18 Adam Williamson 2006-10-09 18:19:56 UTC
We're still getting users bitten by it in MDV 2006, GNOME 2.16:

http://qa.mandriva.com/show_bug.cgi?id=26385
Comment 19 Adam Williamson 2006-10-09 18:20:23 UTC
Er, I meant 2007 :)
Comment 20 Antoine Pitrou 2006-10-09 18:27:50 UTC
Is there a difference between this bug and #348601 ?
Comment 21 Egmont Koblinger 2006-10-10 08:47:47 UTC
Please check bug 342968, the two current (i.e. non-obsolete) patches ("All relevent previous patches against HEAD" and "fix for the recent problem") are believed to fix all the resize issues. We would be happy if you could test them and tell about your experiences in that bugreport; if they are okay, your positive feedback would probably help get them committed to cvs sooner.
Comment 22 Thomas Wood 2006-10-10 09:41:27 UTC
I can confirm the latest patch from bug 95316 also fixes this bug.

These bugs are very irritating if you work with multiple tabs, so if there are
no issues with the patch, please could we get it applied as soon as possible.
Comment 23 Antoine Pitrou 2006-10-10 18:40:31 UTC
How can I build gnome-terminal without touching the rest of my Gnome install?
(and without downloading the whole Gnome sources preferably...)
Comment 24 Pawel Worach 2006-10-17 17:26:56 UTC
Could this be the same problem?

Open a gnome-terminal.
Open a tab so you have two.
Hit Control+- (the font size will get smaller)
Switch between the tabs and watch the gnome-terminal window increase in size on every switch.
Comment 25 Egmont Koblinger 2006-10-18 08:28:42 UTC
Yes, I think it's caused by similar reasons.

As I wrote a few days ago, the patches in bug 342968 are believed to fix _all_ the resizing problems with gnome-terminal. It definitely fixes this one, too. I'd like to ask you to test them and write about your experiences in that bugreport, since I'd pretty much like those patches to get applied asap.
Comment 26 Mariano Suárez-Alvarez 2006-11-15 18:54:33 UTC
*** Bug 368349 has been marked as a duplicate of this bug. ***
Comment 27 Mariano Suárez-Alvarez 2006-11-15 18:55:14 UTC
*** Bug 374942 has been marked as a duplicate of this bug. ***
Comment 28 Mats Ahlgren 2007-02-09 13:04:11 UTC
I've been having resize problems with gnome-terminal version 2.16.1 (comes with SUSE 10.2).

Problem:
When creating new tabs and moving between tabs, gnome-terminal becomes bigger. Eventually it blows up larger than the screen size.

FIX - Patching results:
Problem solved with the following patch (must be applied to SVN):
http://bugzilla.gnome.org/show_bug.cgi?id=342968 ("one patch to bind them all" at the bottom)

Tip:
For people who don't know how to get the source and apply the patch and build it, you can follow the directions I layed out in http://bugzilla.gnome.org/show_bug.cgi?id=324426.
Comment 29 Mariano Suárez-Alvarez 2007-02-09 18:04:22 UTC
Mats and everyone else who has had this problem: could you please try to build gnome-terminal HEAD or 2.17.90, with _no_extra_patches_, and vte 0.15.2 (or HEAD), and see if you can reproduce this problems? 
Comment 30 Antoine Pitrou 2007-02-09 18:49:30 UTC
With 2.17.90 (packaged by Mandriva), the bug seems fixed.
Comment 31 Bryce Nesbitt 2007-02-09 19:27:08 UTC
Man I get this ALL THE TIME.  It's weird.  SUSE 10.2, gnome terminal 2.16.1.

I start out with a little window with 4 tabs.  Each time I touch a tab, the window gets bigger in a single dimension (either X or Y).  Eventually it fills the entire screen. But that's not all.  Soon it will get BIGGER than the screen, and I have to chase to down the corners to resize it.
Comment 32 Adam Williamson 2007-02-09 19:53:00 UTC
Antoine, our (Mandriva's) gnome-terminal package is patched and I believe includes a patch (or more than one) that address this issue. I don't think you can use it as a basis for a reply to Mariano's question.
Comment 33 Antoine Pitrou 2007-02-09 20:05:49 UTC
(In reply to comment #32)
> Antoine, our (Mandriva's) gnome-terminal package is patched and I believe
> includes a patch (or more than one) that address this issue. I don't think you
> can use it as a basis for a reply to Mariano's question.

Ok, sorry then, I didn't know.
(and thanks Mandriva for the packaging :-))
Comment 34 Dennis Cranston 2007-02-09 20:13:47 UTC
I did experience this bug in GNOME 2.16.  I do not see it using GNOME 2.17.x.  I build vte and gnome-terminal from the latest SVN sources.

Comment 35 Mariano Suárez-Alvarez 2007-02-09 20:19:26 UTC
Thanks Antoine, Dennis, Adam!

I've just checked what Mandriva packages as gnome-terminal 2.17.90 <ftp://distrib-coffee.ipsl.jussieu.fr/pub/linux/MandrivaLinux/devel/cooker/SRPMS/main/release/gnome-terminal-2.17.90-1mdv2007.1.src.rpm>, and it does not include any patches on this issue (they just change the default colors, add a --geometry option, and mess with the next/prev tab menu items ( ;-) ))

I'll ask fcrozat, who does the packaging.
Comment 36 Adam Williamson 2007-02-10 01:38:27 UTC
The .src.rpm doesn't lie, so if you see no patches there, we currently have no patches. So that would confirm that 2.17.90 fixes this issue upstream.
Comment 37 Behdad Esfahbod 2007-05-03 01:53:19 UTC
Unfortunately I'm not working on this.  Any takers?
Comment 38 Bryce Nesbitt 2007-05-03 02:22:49 UTC
Note:
SUSE patched this bug, and released the update via YAST.  It works good.
Comment 39 Behdad Esfahbod 2007-05-03 02:25:55 UTC
Can you fetch and attach the patch?
Comment 41 JP Rosevear 2007-05-03 02:38:12 UTC
You've already got it :-).

We applied the patch referenced in #8.

Downstream bug is:
https://bugzilla.novell.com/show_bug.cgi?id=211443
Comment 42 Behdad Esfahbod 2007-11-18 21:54:14 UTC
Chris, got some time to review this patch and commit if it makes sense?
Comment 43 Chris Wilson 2007-11-19 10:32:33 UTC
Heh, that was easy - we've already applied the fix (r2082, bug 95316 :)

Good to finally have closure on this bug...