GNOME Bugzilla – Bug 330417
Spinner icon is loaded only at 16x16 pix
Last modified: 2006-10-18 12:38:01 UTC
Please describe the problem: gnome-icon-theme provides now in head spinner image at 16, 24 and 48 pixels. Nautilus-browser (and Epiphany) grab icon at 16x16 pixels when at least 24 is more appropriate. Steps to reproduce: 1. Update to gnome-icon-theme HEAD 2. Launch Nautilus --browser 3. Open a location Actual results: A small, small, small, very small spinner is showed on toolbar (see attached screenshot) Expected results: Show a proper size spinner Does this happen every time? Yes Other information: 1. see comment 6 and 7 in bug # 328432 2. see same bug report for epiphany (bug #330415)
Created attachment 58940 [details] Nautilus screenshot
The fix is trivial. In nautilus-throbber.c, function nautilus_throbber_load_images() just change the 2 calls to gtk_icon_theme_lookup_icon() from requesting size -1 to size 24 or, IMO preferable, 32. The only problem as I see it is if the buttons on the toolbar are allowed to get very small or too big, then other spinner sizes should be requested.
(In reply to comment #2) > The fix is trivial. In nautilus-throbber.c, function > nautilus_throbber_load_images() just change the 2 calls to > gtk_icon_theme_lookup_icon() from requesting size -1 to size 24 or, IMO > preferable, 32. > Maybe something like if (toolbar_style == ICONS_AND_TEXT) then thobber_size = GTK_SIZE_LARGE_TOOLBAR + 8 else thobber_sile = GTK_SIZE_LARGE_TOOLBAR could be better. Reasons: 1. when your toolbars sytle is "Icons only", you can use for thobber/spinner the same size used for toolbar icons 2. you can't lock the size to 24 or 32 pixels, but you have to respect the size of toolbar icons (you can set this using a GConf key and/or a gtkrc value)
If the code weren't so complicated, I'd already have a patch. I think at least loading the icon at 32x32 for now is the most appropriate option. This will at least get us an appropriately sized image, that won't look overly horrible when it gets scaled down. The correct solution is much more complicated, as the code needs to be able to know what size it's been allocated. I'd say stick in 32 for now, and fix it properly for 2.18 or so, preferrably with a widget in GTK+ that everyone uses, rather than copy+paste code that gets changed between every app that uses it.
it's annoying, it was working fine in 2.14. this is a regression in 2.16.
The same bug for epiphany was fixed (see bug #330415). Maybe we should import back epiphany code. Of course I hope throbber/spinner widgets could be placed in GTK+ (bug #319607)
Created attachment 74658 [details] [review] patch Use ephy-spinner from Epiphany
Created attachment 74894 [details] [review] updated patch with latest spinner code from epiphany
Applied. Thanks.