After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330415 - Spinner icon is loaded only at 16x16 pixel
Spinner icon is loaded only at 16x16 pixel
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
git master
Other All
: Normal major
: 2.16.x
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2006-02-08 15:31 UTC by Luca Ferretti
Modified: 2006-09-29 19:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Epiphany screenshot with small spinner (83.80 KB, image/png)
2006-02-08 15:35 UTC, Luca Ferretti
  Details
proposed patch (4.76 KB, patch)
2006-08-21 20:00 UTC, Rui Matos
none Details | Review
patch (13.66 KB, patch)
2006-09-29 14:20 UTC, Christian Persch
none Details | Review

Description Luca Ferretti 2006-02-08 15:31:31 UTC
Please describe the problem:
gnome-icon-theme provides now in head spinner image at 16, 24 and 48 pixels.

Epiphany (and Nautilus-browser) grab icon at 16x16 pixels when at least 24 is
more appropriate.

Steps to reproduce:
1. Update to gnome-icon-theme HEAD
2. Lauch epiphany
3. Load a page


Actual results:
A small, small, small, very small spinner is showed on toolbar (see attached
screenshot)

Expected results:
Show a proper size spinner

Does this happen every time?
Yes.

Other information:
1. 16x16 spinner is good for the spinner in tabs
2. see comment 6 and 7 in bug # 328432
Comment 1 Luca Ferretti 2006-02-08 15:35:21 UTC
Created attachment 58939 [details]
Epiphany screenshot with small spinner
Comment 2 Luca Ferretti 2006-02-08 15:36:35 UTC
Nautilus bug # 330417
Comment 3 Crispin Flowerday (not receiving bugmail) 2006-02-11 19:09:01 UTC
The current gnome-icon-theme is not being targetted for gnome 2.14 now (see http://mail.gnome.org/archives/desktop-devel-list/2006-February/msg00309.html) so this needs to be fixed by ephy 1.12.
Comment 4 Daniel Holbach 2006-07-28 08:59:25 UTC
Mentioned in https://launchpad.net/distros/ubuntu/+source/epiphany-browser/+bug/54274 as well
Comment 5 Rui Matos 2006-08-21 20:00:35 UTC
Created attachment 71333 [details] [review]
proposed patch

This is a diff against version 2.15.91-0ubuntu1. It has been working for me for some hours now, I'm using gnome-icon-theme 2.15.91-0ubuntu2.

Please review,

thanks
Comment 6 Christian Persch 2006-09-29 14:20:38 UTC
Created attachment 73639 [details] [review]
patch

This should fix the problem, as well as fix a crash when failing to load some spinner icon data (gedit bug 357456).

Can someone using gnome 2.16 please stress-test the patch (switching themes back and forth while having the spinner spin)? There's a test program in lib/widgets, compile with
gcc `pkg-config --libs --cflags gtk+-2.0` -g -o testspinner testspinner.c
Comment 7 Christian Persch 2006-09-29 19:24:41 UTC
Fixed in CVS. The fix will go into the next patch release. Thank you for your bug report.
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.