GNOME Bugzilla – Bug 328432
epiphany needs gnome-spinner.png and gnome-spinner-rest.png
Last modified: 2006-07-09 14:21:05 UTC
Please describe the problem: $epiphany ** (epiphany:15191): WARNING **: Could not load the spinner file gnome-icon-theme-2.13.5.1 Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? always Other information: epiphany-1.9.5.1
beagle-search does not even start without gnome-spinner-rest: [adamw@zen Documents]$ beagle-search (search:8656): Gtk-WARNING **: Theme directory 16x16/status16x16/stock/chart of theme gnome has no size field Unhandled Exception: GLib.GException: Icon 'gnome-spinner-rest' not present in theme in <0x00099> Gtk.IconTheme:LoadIcon (System.String icon_name, Int32 size, IconLookupFlags flags) in <0x00069> Search.Spinner:LoadImages () in <0x0006d> Search.Spinner:OnRealized () in <0x00036> Gtk.Widget:realized_cb (IntPtr widget) in (wrapper native-to-managed) Gtk.Widget:realized_cb (intptr) in <0x00000> <unknown method> in (wrapper managed-to-native) Gtk.Widget:gtk_widget_show_all (intptr) in <0x00017> Gtk.Widget:ShowAll () in <0x00875> Search.MainWindow:.ctor () in <0x00096> Search.MainWindow:Main (System.String[] args) [adamw@zen Documents]$
The spinner images are now included in CVS and the 2.13.7 release.
strange!!! this problems happen in gnome-icon-theme 2.13.7, icon-naming-utils-0.6.7. $epiphany ** (epiphany:12017): WARNING **: Throbber animation not found $ rpm -ql gnome-icon-theme-2.13.7 | grep spinner /usr/share/icons/gnome/16x16/animations/gnome-spinner-rest.png /usr/share/icons/gnome/16x16/animations/gnome-spinner.png /usr/share/icons/gnome/24x24/animations/gnome-spinner-rest.png /usr/share/icons/gnome/24x24/animations/gnome-spinner.png /usr/share/icons/gnome/48x48/animations/gnome-spinner-rest.png /usr/share/icons/gnome/48x48/animations/gnome-spinner.png copy in old gnome-icon-theme packages. /usr/share/icons/hicolor/36x36/apps/gnome-spinner-rest.png /usr/share/icons/hicolor/36x36/apps/gnome-spinner.png $gtk-update-icon-cache --quiet /usr/share/icons/hicolor this problem is fixed.
index.theme has not been updated to include the animation directories, so it is still broken in 2.13.7
Using latest (updated 5 minutes ago) g-i-t and i-n-u there is another issue: bot gnome-spinner and gnome-spinner-rest are loaded only at 16x16 size. index.theme seems good... strange.
Created attachment 58870 [details] The strace output loading epiphany It seems that 24x24 is ignored only loading spinner. Maybe it's a bug in spinner code? open("/opt/gnome2/share/icons/gnome/24x24/actions/gtk-refresh.png", O_RDONLY|O_LARGEFILE) = 21 fstat64(21, {st_mode=S_IFREG|0644, st_size=1072, ...}) = 0 mmap2(NULL, 131072, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb5868000 read(21, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0\30\0\0\0\30\10\6\0\0"..., 131072) = 1072 _llseek(21, 0, [0], SEEK_SET) = 0 read(21, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0\30\0\0\0\30\10\6\0\0"..., 131072) = 1072 close(21) = 0 munmap(0xb5868000, 131072) = 0 gettimeofday({1139327882, 496270}, NULL) = 0 gettimeofday({1139327882, 501120}, NULL) = 0 open("/opt/gnome2/share/icons/gnome/16x16/animations/gnome-spinner.png", O_RDONLY|O_LARGEFILE) = 21 fstat64(21, {st_mode=S_IFREG|0644, st_size=4558, ...}) = 0 mmap2(NULL, 131072, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0xb5868000 read(21, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0p\0\0\0P\20\6\0\0\0\221"..., 131072) = 4558 _llseek(21, 0, [0], SEEK_SET) = 0 read(21, "\211PNG\r\n\32\n\0\0\0\rIHDR\0\0\0p\0\0\0P\20\6\0\0\0\221"..., 131072) = 4558 close(21) = 0 munmap(0xb5868000, 131072) = 0 gettimeofday({1139327882, 515126}, NULL) = 0 open("/opt/gnome2/share/icons/gnome/16x16/animations/gnome-spinner-rest.png", O_RDONLY|O_LARGEFILE) = 21 fstat64(21, {st_mode=S_IFREG|0644, st_size=336, ...}) = 0 :
No. The problem is that a size of -1 is being requested. This means that the smallest size available will get used, as it is the closest match to -1. This means that the code needs to be fixed to request proper sizes based on the size of the widget that is containing the image, rather than using -1. I'm surprised this hasn't come up until now, really.
Bug for nautilus: # 330417 Bug for epiphany: # 330415
Well, in the old icon theme, the spinner was only available at a 'native' size and the spinner code is doing the scaling to use the images at the size the spinner wants to have (we support all GtkIconSizes, and epiphany uses it in GTK_ICON_SIZE_MENU, BUTTON, LARGE_TOOLBAR, and the old native 36x36 size.)
This bug was fixed in gnome-icon-theme-2.14.0.
Please do not close bugs against g-i-t as "fixed in 2.14.0", as the bugs need to remain open for 2.15. 2.14.0 is an old revision of git, to satisfy needs for GNOME 2.14.0 and restructuring will continue on HEAD for 2.15/2.16.
OK. This icon is in HEAD and available in 16, 22, 24, and 48 pixel sizes. A 32x32 frame animation will be available soon as well. I'm closing this as fixed. As far as the spinner code in Epiphany and Nautilus go, they need to be fixed to look up the correct size for the icon, and not -1, then doing scaling.