After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329823 - Feature Request: Icon change to reflect new mail
Feature Request: Icon change to reflect new mail
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.6.x
Other All
: Normal minor
: ---
Assigned To: Milan Crha
Evolution QA team
: 251224 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-02-03 19:21 UTC by David Richards
Modified: 2013-09-13 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Icon change mockup to reflect new messages. (103.22 KB, image/png)
2006-02-03 19:22 UTC, David Richards
  Details
proposed evo patch (10.76 KB, patch)
2007-10-03 10:48 UTC, Milan Crha
reviewed Details | Review
proposed evo patch ][ (13.98 KB, patch)
2007-10-09 08:30 UTC, Milan Crha
committed Details | Review

Description David Richards 2006-02-03 19:21:59 UTC
When in a view besides email, it would be nice to get a visual cue that new
email has arrived.  Right now, you have to keep flipping back to Mail to see if
something has come in.  The old GW 4.1 used to change the icon to show you that
mail has arrived, which was useful.

I made a mockup of how this might look, note button in lower left hand corner
with envelope sitting in an Inbox, which would appear when something new arrives.

Other information:
Comment 1 David Richards 2006-02-03 19:22:54 UTC
Created attachment 58663 [details]
Icon change mockup to reflect new messages.
Comment 2 André Klapper 2006-02-05 03:05:35 UTC
very related to bug 259156
Comment 3 Milan Crha 2007-10-03 10:48:40 UTC
Created attachment 96563 [details] [review]
proposed evo patch

for evolution;

This patch adds a support to access sidebar buttons of the main shell, and in this case to change its icon. It can be easily extended to change tooltips too.
There is only one thing, I'm not sure with a design of this solution, just say if you have better suggestion where to place and how to name functions/types.
(From my point of view, it works just cool. Good suggestion Dave.) ;)
Comment 4 Matthew Barnes 2007-10-03 11:10:10 UTC
We could also make the taskbar button blink when new mail arrives, much like XChat and Pidgin.  I'm sure users would insist on an option for this though.
Comment 5 Milan Crha 2007-10-03 11:16:05 UTC
Yes, I was thinking about it too, but wasn't sure if it isn't disturbing for user. Not every mail is important, so hard to say. Option can help, of course.
Comment 6 Srinivasa Ragavan 2007-10-04 08:17:55 UTC
Milan, Matthew, sounds fine to me. But blinking the taskbar? May not be a good option. We force the user to switch and read mail. We won't/don't have a mechanism to switch it off otherwise. (like clicking the tray to get it off)

Comment 7 Matthew Barnes 2007-10-05 20:32:57 UTC
Srini: Question about Milan's patch.

Even though Evolution's components are really just shared libraries, does it violate the design for components to directly call EShell functions?  I thought all communication between the shell and the components had to happen via Bonobo.

The rest of Milan's patch looks solid.  I'll test it further over the weekend.
Comment 8 Srinivasa Ragavan 2007-10-06 18:42:59 UTC
Mbarnes, very much. Just see how the set_title is implemented. It gotto do the same/similar way.
Comment 9 Milan Crha 2007-10-09 08:30:44 UTC
Created attachment 96922 [details] [review]
proposed evo patch ][

for evolution;

Same thing but with bonobo, so without get_main_shell.
Comment 10 Srinivasa Ragavan 2007-10-11 05:44:55 UTC
The patch/design looks fine to me. Please compile/test and commit.
Comment 11 Milan Crha 2007-10-11 14:04:30 UTC
Committed to trunk. Committed revision 34374.
Comment 12 Matthew Barnes 2007-10-11 14:17:27 UTC
Gah, I didn't get around to testing this in time.

One thing I wanted to mention is I think the "Mail" button text should also be bolded when new mail arrives, in case the user is using "Text only" switcher appearance.
Comment 13 Matthew Barnes 2007-10-11 14:39:59 UTC
Also, we really need better looking icon than "stock_mail" for where there are no new messages.  The difference in quality between the two icons is stark.
Comment 14 Milan Crha 2008-04-01 11:40:50 UTC
*** Bug 251224 has been marked as a duplicate of this bug. ***