After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319758 - Podcast: resume partial downloads
Podcast: resume partial downloads
Product: rhythmbox
Classification: Other
Component: Podcast
Other Linux
: Normal major
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 330385 (view as bug list)
Depends on: 510392
Reported: 2005-10-25 15:07 UTC by Ryan P Skadberg
Modified: 2008-07-29 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (7.24 KB, patch)
2005-10-27 07:24 UTC, James "Doc" Livingston
none Details | Review
patch (8.55 KB, patch)
2005-10-27 19:37 UTC, Renato Araujo Oliveira Filho
none Details | Review
updated patch (8.09 KB, patch)
2005-10-28 01:58 UTC, James "Doc" Livingston
committed Details | Review

Description Ryan P Skadberg 2005-10-25 15:07:24 UTC
Distribution/Version: Fedora Core Rawhide

Due to having RB crash from time to time and not having the Podcast db updated,
I end up downloading some files multiple times.  It would be nice (as the RSS
has the size of the file) to compare the size of the file in place with the size
given by the RSS feed and not try to re-download it.
Comment 1 James "Doc" Livingston 2005-10-27 07:24:09 UTC
Created attachment 53937 [details] [review]

This patch makes RB check an existing file, and if it is the same size as the
feed says it doesn't download it again.

There is an obvious place to add support for resuming partialally downloaded
podcasts - but AFAICT the gnome-vfs xfer functions don't have support for doing
Comment 2 Ryan P Skadberg 2005-10-27 16:16:16 UTC
This doesn't seem to work for me.  I downloaded a podcast, killed RB before it
got written to the DB and then tried to download again and it re-downloaded the
file.  I used the Download Post in the right click menu.
Comment 3 Renato Araujo Oliveira Filho 2005-10-27 19:37:42 UTC
Created attachment 53960 [details] [review]

i made some changes in the James's patch
Comment 4 Ryan P Skadberg 2005-10-27 20:11:20 UTC
Renato's patch crashes RB.  Attached is a BT
Comment 5 James "Doc" Livingston 2005-10-28 01:58:32 UTC
Created attachment 53969 [details] [review]
updated patch

The last patch accidently removed one of the fixes that has just been committed
to cvs - the fix for the crash you were seeing.
Comment 6 Ryan P Skadberg 2005-10-28 15:45:50 UTC
This latest patch seems to work correctly, yay!
Comment 7 James "Doc" Livingston 2005-10-28 16:32:07 UTC
Patch committed to cvs. Retitling for resuming partially-downloaded podcasts.
Comment 8 Baptiste Mille-Mathias 2006-01-17 16:19:31 UTC
Change to "Podcast" Component
Comment 9 James "Doc" Livingston 2006-02-15 09:51:14 UTC
*** Bug 330385 has been marked as a duplicate of this bug. ***
Comment 10 James "Doc" Livingston 2006-02-15 10:01:36 UTC
There is a TODO in the code for this, in rb_podcast_manager_copy_post().

I'm not sure if gnome_vfs_async_xfer supports a "resume" option, which would make this easy.
Comment 11 Alex Lancaster 2006-05-07 13:58:36 UTC
Back on dial-up and I had my modem connection die during a long podcast download.  It had been downloading for about 45 mins.  Then I restarted rhythmbox and the podcast restarted downloading all over again!  Grrr.  

This is a bad behaviour because it is destructive of previous downloads, at the very least it should offer to back-up the file.  Is there not any other way to make this work other than via gnome_vfs-async_xfer()?
Comment 12 James "Doc" Livingston 2006-05-08 14:08:06 UTC
We could write some code which does exactly what gnome_vfs_async_xfer does, except that it supports resume ;)

The big issue is that we'd need to fix bug 330766 first, otherwise we can't tell whether it's a partially downloaded episode, or a completely different episode with the same file name.
Comment 13 Artem Baguinski 2007-09-03 14:25:56 UTC
Could this resume functionality be added to gnome vfs and then used by RB? 
Comment 14 Alex Lancaster 2007-09-03 20:23:23 UTC
(In reply to comment #13)
> Could this resume functionality be added to gnome vfs and then used by RB? 

You'd have to ask the gnome-vfs developers, best thing would be to open new a bug for gnome-vfs requesting a resume function, then make this bug depend on that bug. 

Comment 15 Jonathan Matthew 2007-09-03 22:16:50 UTC
My understanding is that no new features will be added to gnome-vfs.  Instead, we should make sure that gvfs (which is replacing gnome-vfs) will allow us to resume transfers.
Comment 16 Jonathan Matthew 2008-03-06 13:45:00 UTC
.. and indeed it does.  My gio port tree now has working podcast download resumption.
Comment 17 Jonathan Matthew 2008-07-29 13:18:07 UTC
.. which has now been committed to svn.