GNOME Bugzilla – Bug 211082
conflicting contacts can not be merged
Last modified: 2013-09-10 14:04:48 UTC
Say I have a contact called Fred with an email address of "fred@foo.com" in the Contacts folder. If I right-click on an email from Fred which came from another email address, I enter the name "Fred" again and Evolution says that a contact with that name already exists. I think that I should be able to merge the contacts somehow so that I have one contact with both email addresses.
This already happens when you right-click on something with the same name as an existing contact but with a different e-mail address. It should also happen when you enter the name of an existing contact by hand.
evo1.4.4-54 lets me "select an action" whether to "create a new contact" or to "add address to existing contact". if i choose the last one, i can merge. closing this one.
*** bug 215464 has been marked as a duplicate of this bug. ***
(I really should have re-opened this earlier) Say I have a contact in my address book, "Fred Bloggs". I get an email from him where the name is written "Dr Fred Bloggs", which has a new email address. I right-click on the name, select Add to Addressbook. Evo doesn't let me edit the existing contact as the names are different, fair enough. I change the name to "Fred Bloggs", press Add, and Evolution says that there is already a contact with this name, and I have to either add it as another contact or cancel the operation. Ideally at this point it would open the contact editor and let me add the new data as I see fit.
*** This bug has been marked as a duplicate of 270184 ***
This is *not* a duplicate of bug 270184. This one is about broken "match contacts" option with *identical* names. I can confirm this. REOPENing.
*** Bug 319468 has been marked as a duplicate of this bug. ***
I can *fully* reproduce this bug. Steps to reproduce this issue: * Have a Contact "Name Surname" in your address book "Target". * Right click the email address in the mail, chose Add to Address Book. * Try adding it as "Name Surname" to the "Target" Address Book. The "Duplicate Contact Detected" dialog states: "The name or email address of this contact already exists in this folder. Would you like to add it anyway?" However, the options available are: * Cancel: which will *not* add anything to the Address Book * Add: which results in a *duplicate* Contact There is *no* option to merge these Contacts. a) You can not add a new email address to an existing Contact. b) You can not add an email address to a Contact that doesn't have one yet. It does not matter at all, wheather the Contacts name is modified in the Contact Quick-Add dialog or the very same as it appears in the email. It does not matter at all, if the email you right-clicked in the first place happens to be in the mail header or the body. It does not matter, which Address Book is chosen as the target. Evolution 2.6.0.This is a REGRESSION. Raising Priority and Severity. Setting usability keyword.
*** Bug 343503 has been marked as a duplicate of this bug. ***
Created attachment 69715 [details] [review] merge option added to the dialogue
gui/merging/eab-contact-duplicate-detected.glade part of the patch is missing.
Created attachment 69782 [details] [review] merge option added to the dialogue
I guess we need a better merging dialog for all fields. Just email is not a solution. Ushveen you can design one as per our discussion. Im marking this patch for more work,
Created attachment 70062 [details] [review] resubmitted.
Sushma? Can you also review it?
I'd love to see this happen, too. My contact list is a mess -- I need to merge a bunch of duplicates collected over years, from IM clients and from email.
Not sure if this has been merged or not? I'm using 2.7.92 and still seeing the same problem. If I copy and paste a contact into the same addressbook I only get add/cancel options in the duplicate dialog box.
Matthew, it breaks UI/STRING freeze. Cant commit to 2.8. Should be part of next release.
always feel free to review and set to accepted-commit_after_freeze (i know you're busy, this is meant as a general hint)
Ushveen, I see that the patch works well. Ofcourse it required some rework. I18n isnt taken care. Also few loops can be avoided. And few coding styles. Decl has to be in the beginning. Can u correct them. Also some code comments :)
Created attachment 75928 [details] [review] Resubmitting with all the rework mentioned by srini.
The patch looks much better. Im still wondering where the dropdown data is freed?
i dislike inline comments like these w = table->allocation.width + 30 /* Spacing around the table */; which make the code harder to read, but i'm really looking forward to see this getting in for 2.9.x and am happy that somebody works on this.
Created attachment 76064 [details] [review] Resubmitting.
So, did this patch make it in for 2.9? It's really the main piece of functionality I need to make the Contacts manager useful.
Evan, Ushveen's patch had a few issues which Ebby was working on. He finished his work last week. It is in target for 2.11.1. I will commit that for 2.11.1
Committed to svn trunk. It works fine. I suspect it needs more testing.
Bumping version to a stable release.
*** Bug 200600 has been marked as a duplicate of this bug. ***
(In reply to comment #27) > Committed to svn trunk. It works fine. I suspect it needs more testing. This is supposed to be fixed for almost two years. I'm closing it, because trying steps from comment #8 offers me a Merge option.