After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162136 - Make the pattern viewer scale patterns to fit in the viewbox
Make the pattern viewer scale patterns to fit in the viewbox
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: User Interface
2.2.x
Other All
: Low enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
: 623531 795528 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-12-24 00:44 UTC by Daniel Llano
Modified: 2018-05-24 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Daniel Llano 2004-12-24 00:44:03 UTC
Make the pattern viewer scale patterns to fit in the viewbox.
This way you can see the whole pattern if it's to big or you can see it better
if it's to small.
Comment 1 weskaggs 2004-12-24 16:09:09 UTC
No!  If it did that, you would never know what the result was going to look like
when you fill a region with a pattern.  And anyway this is not needed.  If you
want to view the whole pattern, you can hold the left button down with the mouse
over it in the Patterns dialog.  If the pattern is too small, well, that's what
it is going to look like if you use it, so you should probably choose a
different pattern.

(Don't let this response discourage you from making other suggestions, though,
please.  We appreciate your effort.)
Comment 2 Daniel Llano 2004-12-24 16:53:18 UTC
If you want to know how it will look like once applied you should click on it to
show the preview.
I want to see the whole pattern in a quick view. Seeing only a small top-left
region of the pattern is not enough and is not practical.
Comment 3 Dave Neary 2004-12-26 18:50:01 UTC
I agree with Daniel that scaling the patern is the better thing to do.

To see why, create a 256x256 pattern, with the top right corner transparent, and
see how usefl the patterns dock is to you.

Bill, you have answered your own counter-argument - to see how the pattern will
look when you fill a region, click the pattern to get a full-size preview.

Since we do this already in the layers & channels docks, I can't imagine that
doing the same for patterns would be particularly complicated.
Comment 4 Michael Schumacher 2004-12-26 19:05:12 UTC
Scaling down large patterns might give a completely wrong impression of the
pattern, though - IMO in more cases than the current solution.

However, the patterns should probably get indicators showing that not the whole
or a scaled view is displayed - smiliar to the brushes.
Comment 5 Daniel Llano 2004-12-26 19:35:59 UTC
Mich, If you don't want the pattern quick view maybe this scaling should be
optional.

My problem is that I can't take a quick look at the patterns since seeing the
top left corner doesn't help.

Mich, If you want to see the "real" size of the pattern you can click on the
pattern anyway.
Comment 6 Joao S. O. Bueno 2005-01-12 14:28:10 UTC
Just to add one thing to this discussion: 
It is being talked about adding categories to gimp resources. Patterns would 
be one of the resources to benefit from it. 
 
I can all but think that these categories of objects will be managed, from a 
UI point of view, much like palettes are right now - there is a dialog for 
palettes, and a pallete editor dialog which allows for viewing each palette 
contents. 
 
Therefore, not only the pattern preview size could be variable in such 
"pattern category editor dialog", but if they should be scaled for previewing 
could be a property from the category itself. 
 
I apologize for mixing different issues here, but as all the resources dialogs 
will have to be reviewed to deal with the upcoming categories, this have to be 
taken into account in this bug. 
 
 
Comment 7 Daniel Llano 2005-01-12 15:27:35 UTC
Adobe Photoshop also scales the patterns to fit in the viewbox.
Comment 8 Michael Natterer 2014-02-23 01:33:20 UTC
*** Bug 623531 has been marked as a duplicate of this bug. ***
Comment 9 David Gowers 2015-03-22 23:20:39 UTC
It seems to me that for the 'pattern is too small' case, there is an uncontroversial solution, at least:
Tile the pattern an integer number of times across the available display area.

For the thumbnail display, 'available display area' is dictated by the thumbnail settings of the pattern dialog, of course.
For the popup display, I'd suggest a limit of 40% of the current screen's width+height (for example, on my 1680x1050 screen, the limit could be 672x420), snapped to an integer amount of tiles. So with the example of 672x420 limit, and 32x32 pattern, the actual popup would be 672 x 416 (21 x 13 instances of the pattern.)

(patterns as small as 1x2 or 2x1 are still useful. It helps preview currently if we tile these up to say 32x32 before saving, but of course this means that if we need to edit them, we are required to shrink the canvas, crop the layer, make our edits, and then tile them up to 32x32 again.)
Comment 10 Michael Natterer 2018-04-25 10:00:18 UTC
*** Bug 795528 has been marked as a duplicate of this bug. ***
Comment 11 GNOME Infrastructure Team 2018-05-24 11:19:41 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/110.