After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 129095 - Layerborder is not cleared when the layer is deleted
Layerborder is not cleared when the layer is deleted
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.2.x
Other Windows
: Normal major
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
: 126944 137177 137692 141413 141446 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-12-11 15:03 UTC by Joonas Paalasmaa
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot showing badly drawn outside-image. (7.56 KB, image/png)
2004-01-16 15:00 UTC, Dave Neary
Details

Description Joonas Paalasmaa 2003-12-11 15:03:25 UTC
When I deleted a layer whose border was partially outside the image area,
only the parts of the layer's border that were on the image area were cleared.

See http://speedloop2000.com/tmp/layerborder.png
Comment 1 Sven Neumann 2003-12-11 16:36:14 UTC
This is certainly not reproducible here. Itc ould be a bug in the
win32 GDK port. Can you please tell us exactly what versions of GIMP
and GTK+ you are using and, if you use precompiled binaries, where you
got them from.
Comment 2 Joonas Paalasmaa 2003-12-11 17:28:14 UTC
I am using gimp-1.3.23-i686-setup.zip from
http://www2.arnes.si/~sopjsimo/gimp/unstable.html

I can reproduce the problem with both gtk+-2.2.4-setup.zip from
http://www2.arnes.si/~sopjsimo/gimp/unstable.html and with
GTK-Runtime-Environment-2.2.4.1.exe from
http://www.dropline.net/gtk/download.php
Comment 3 Sven Neumann 2003-12-11 18:51:53 UTC
That package is not build from gimp-1.3.23. It is from a CVS snapshot
that was taken a week or two before the 1.3.23 release. The problem was
fixed in this time-frame. Version 1.3.23 doesn't show this behaviour.
Comment 4 Joonas Paalasmaa 2004-01-16 10:32:15 UTC
I would like to report that the problem is reproducible in GIMP
version 2.0pre1. I am using gimp-2.0-pre1-i686-setup.zip and
gtk+-2.2.4-setup-1.zip from
http://www2.arnes.si/~sopjsimo/gimp/unstable.html.
Comment 5 Dave Neary 2004-01-16 15:00:39 UTC
Created attachment 23441 [details]
Screenshot showing badly drawn outside-image.
Comment 6 Dave Neary 2004-01-16 15:03:14 UTC
Hi. 

Confirmed on Win32, could not reproduce on RH 8.

I have attached a screenshot with the bad behaviour. Once the window
goes behind and gets redrawn, the edge traces go away. Perhaps there
is a way to force the window to redraw on windows that we're not using?

Cheers,
Dave.
Comment 7 Dave Neary 2004-01-20 09:15:58 UTC
*** Bug 126944 has been marked as a duplicate of this bug. ***
Comment 8 Sven Neumann 2004-01-20 10:07:02 UTC
Reassigning this GIMP bug to GTK+ since it is obviously a GDK problem.
The layer boundary is actively deleted and this works reliably on X11.
Comment 9 Kent Paul Dolan 2004-01-21 04:06:10 UTC
Probably the status should be upgraded from "UNCOMFIRMED", which it
has been, to however you spell "SOMEBODY ELSE'S PROBLEM", which it
might be.

HTH.

xanthian@well.com
Comment 10 Owen Taylor 2004-01-21 15:38:52 UTC
We don't pay attention to UNCONFIRMED vs. NEW vs. ASSIGNED
for GTK+. But I'll move it to NEW if that makes you feel
better.
Comment 11 Sven Neumann 2004-04-30 01:24:21 UTC
*** Bug 141413 has been marked as a duplicate of this bug. ***
Comment 12 Sven Neumann 2004-04-30 01:24:36 UTC
*** Bug 141446 has been marked as a duplicate of this bug. ***
Comment 13 Hans Breuer 2004-05-02 13:29:10 UTC
Patch applied to cvs, leaving bug open to give future reporters
a chance to find their duplicate ;)

2004-05-02  Hans Breuer  <hans@breuer.org>

	* gdk/win32/gdkdrawable-win32.c (draw_segments) : don't
	modify the passed in GdkSegment(s) in place, we may get
	them again to draw at the same place. Fixes bug #129095, 
	bug #137177, ...
	(draw_segments) draw the end pixel again to get the 
	pixmap mask right, fixes bug #126710, #130202

Comment 14 Hans Breuer 2004-05-02 13:30:04 UTC
*** Bug 137177 has been marked as a duplicate of this bug. ***
Comment 15 Tor Lillqvist 2004-05-02 19:47:28 UTC
> don't	modify the passed in GdkSegment(s) in place, we may get
> them again to draw at the same place.

(sounds of head banging against wall)

Thanks. With hindsight, how painfully obvious.

Pity this was fixed just after 2.4.1 was released. I am tempted to include this 
fix anyway in the 2.4.1 binaries I am just building.
Comment 16 Tor Lillqvist 2004-05-14 04:06:54 UTC
*** Bug 137692 has been marked as a duplicate of this bug. ***
Comment 17 Elijah Newren 2004-06-19 18:42:37 UTC
Mass changing gtk+ bugs with target milestone of 2.4.2 to target 2.4.4, as
Matthias said he was trying to do himself on IRC and was asking for help with. 
If you see this message, it means I was successful at fixing the borken-ness in
bugzilla :)  Sorry for the spam; just query on this message and delete all
emails you get with this message, since there will probably be a lot.
Comment 18 Michael Schumacher 2004-07-03 05:50:36 UTC
Doesn't happen anymore with GTK+ 2.4.3. Is comment 13 supposed to mean that it
should be kept open nevertheless?
Comment 19 Matthias Clasen 2004-07-03 06:15:23 UTC
I don't think we should keep bugs open just as duplicate targets.