After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744912 - Cannot drag windows into desktops
Cannot drag windows into desktops
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 745573 745641 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-02-21 20:39 UTC by Jason Ekstrand
Modified: 2015-03-05 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: Fix actor visibility (1.11 KB, patch)
2015-02-26 12:37 UTC, Florian Müllner
committed Details | Review
messageTray: Take over trayBox from LayoutManager (10.48 KB, patch)
2015-02-26 12:37 UTC, Florian Müllner
committed Details | Review
messageTray: Hide from picks during DND operations (2.25 KB, patch)
2015-02-26 12:37 UTC, Florian Müllner
committed Details | Review

Description Jason Ekstrand 2015-02-21 20:39:38 UTC
I just updated to 3.15.90 this morning and now I can't drag a window into a different desktop from the overview.  All you have to do to reproduce is start two terminals and try to drag one into the second desktop.  No dice.
Comment 1 Florian Müllner 2015-02-21 21:00:32 UTC
Sorry, my fault :-(

I'm aware of the issue (since yesterday) and will get to it after the weekend at the latest - it's that none of the possible fixes I've come up so far convinces me too much ...
Comment 2 Florian Müllner 2015-02-26 12:37:04 UTC
Created attachment 297968 [details] [review]
messageTray: Fix actor visibility

The actor is supposed to be hidden while no notification banner
is displayed, and in addition to that when banners are temporarily
blocked (because the calendar is open). However the current code
always shows the actor when banners are not blocked, fix that.
Comment 3 Florian Müllner 2015-02-26 12:37:10 UTC
Created attachment 297969 [details] [review]
messageTray: Take over trayBox from LayoutManager

Since commit e189a34, the trayBox uses a Contraint to cover the primary
monitor's work area. This allows banners to be clipped so they don't
leak into monitors above the primary one during animations. However even
without being reactive, the trayBox now interferes with operations like
Looking Glass' object picker and overview DND.
With the trayBox no longer being positioned manually, there's no strong
reason to keep it in LayoutManager, and handling it in MessageTray allows
to hide the actor while no banner is showing, which helps with the issue
outlined above.
Comment 4 Florian Müllner 2015-02-26 12:37:18 UTC
Created attachment 297970 [details] [review]
messageTray: Hide from picks during DND operations

As it is impossible to interact with notification banners while a DND
operation is ongoing, we can temporarily hide the banner container from
picks so that DND works as expected even while a banner is showing.
Comment 5 drago01 2015-02-27 12:32:33 UTC
Review of attachment 297968 [details] [review]:

LG.
Comment 6 drago01 2015-02-27 12:35:45 UTC
Review of attachment 297969 [details] [review]:

LG.
Comment 7 drago01 2015-02-27 12:37:49 UTC
Review of attachment 297970 [details] [review]:

::: js/ui/messageTray.js
@@ +1568,3 @@
+                              Lang.bind(this, this._onDragEnd));
+        Main.overview.connect('item-drag-end',
+                              Lang.bind(this, this._onDragEnd));

Shouldn't this be done for xdnd drags as well?
Comment 8 Florian Müllner 2015-02-27 13:25:21 UTC
(In reply to drago01 from comment #7)
> Shouldn't this be done for xdnd drags as well?

Makes sense, yes - I added that before pushing.


Attachment 297968 [details] pushed as 5f5dc83 - messageTray: Fix actor visibility
Attachment 297969 [details] pushed as b3a96f2 - messageTray: Take over trayBox from LayoutManager
Attachment 297970 [details] pushed as d564117 - messageTray: Hide from picks during DND operations
Comment 9 drago01 2015-03-04 07:52:05 UTC
*** Bug 745573 has been marked as a duplicate of this bug. ***
Comment 10 Florian Müllner 2015-03-04 21:58:07 UTC
*** Bug 745641 has been marked as a duplicate of this bug. ***
Comment 11 Florian Müllner 2015-03-05 11:36:16 UTC
*** Bug 745635 has been marked as a duplicate of this bug. ***