GNOME Bugzilla – Bug 549267
Mouse Preferences are not taken into use when a mouse is plugged in
Last modified: 2008-11-07 20:07:31 UTC
Please describe the problem: If a (USB) mouse is unplugged from the system and plugged back in the mouse settings defined using the Mouse Preferences window (such as Acceleration and Sensitivity) are not taken into use. Default values are used instead. The user has to open the Mouse Preferences window and touch the Acceleration/Sensitivity controls in order to get the mouse functioning as preferred. Steps to reproduce: 1. Unplug USB mouse. 2. Plug USB mouse back in. Actual results: The mouse pointer moves according to some default acceleration/sensitivity values. Expected results: The mouse pointer should move according to the acceleration/sensitivity values set using the Mouse Preferences window. Does this happen every time? Yes. Other information: This is particularly annoying when the mouse is plugged into a USB hub integrated into a monitor; when the monitor is powered off the hub is also powered off and all devices get disconnected. When the monitor is powered back on the mouse does not work as expected.
*** Bug 553587 has been marked as a duplicate of this bug. ***
*** Bug 556875 has been marked as a duplicate of this bug. ***
*** Bug 558644 has been marked as a duplicate of this bug. ***
Created attachment 121760 [details] [review] patch with complaints resolved I've resolved Jens' issues with my patch from bug #558644. I think I've matched all of the new code with the rest of the coding style. It now builds and works (albeit with the bug this change fixes) without HAVE_XINPUT defined.
Looks pretty good. One thing I missed in the first review is that you need to remove the filter again in _stop so that the plugin can be properly unloaded. Regarding the HAVE_XINPUT, there already are a few #ifdef blocks in the file. If you just move the respective funtions into on of those blocks, you'd not need a new ifdef. The ifdef in _start should start in the first column.
Created attachment 121771 [details] [review] patch the third Oh, good catch on that filter removal. I've also reshuffled things and fixed the #ifdef indentation.
2008-11-01 Jens Granseuer <...> Patch by: William Grant <...> * plugins/mouse/gsd-mouse-manager.c: (devicepresence_filter), (set_devicepresence_handler), (set_mouse_settings), (gsd_mouse_manager_start), (gsd_mouse_manager_stop): listen for X device changes, and reconfigure the mouse if necessary so that the settings aren't ignored when hotplugging (bug #549267)
*** Bug 559693 has been marked as a duplicate of this bug. ***