GNOME Bugzilla – Bug 167944
Detached Toolbars unable to move/reattach
Last modified: 2006-10-22 14:35:11 UTC
Version details: 2.8.1 Distribution/Version: Gentoo With libbonoboui, I can't move a detached toolbar after the initial move from the application. Steps to reproduce: drag toolbar from application to any spot on the desktop try and move toolbar again
reproduced here as well: http://bugs.gentoo.org/show_bug.cgi?id=82384
There's a workaround I discovered: press space when the toolbar handle has focus and it will re-attach itself to the main window.
Same bug in gnome 2.10.1 fedora core 3 rpms from nrpms.net
Federico - I thought this got fixed ? :-)
This is still a problem with 2.12
Confirmed with libbonobo 2.10.0
*** Bug 311511 has been marked as a duplicate of this bug. ***
*** Bug 274287 has been marked as a duplicate of this bug. ***
Created attachment 50029 [details] [review] patch for bonobo-dock-item.c resolve floating mode problem All those bugs disappear but then we change with 'gconf-editor' the key'/desktop/gnome/interface/toolbar_detachable' from '1' to '0' (or by gnome gnome-ui-properties) and toolbar is floating, it remain floating without grip...
*** Bug 272376 has been marked as a duplicate of this bug. ***
did the patch get any attention already?
I want to know - work my patch? or only on my machine ?
2.14 is approaching and this still isn't fixed :(
Pavel, can you describe the reason of problem and why you patch makes thing work? It's unclear for me how can you remove detachable window.
Ohh... English for me is more diffiсult that 'C' or 'C++' ;-) maybe Russian ;-))) Usind 'gdb' and 'xwininfo' I see what floating window don't receive some (motion) events, and 'greep' is widget what hasn't own X window it use parent window ... I use a gdk 'floating' window instead. And reparent child panel to it when it's showed. And vice versa ... However main widow lose focus if I set it in the grip ;-(
Yeah, now I see, there reason is that BonoboDockItemGrip can't handle button press itself and the parent window that contains BonoboDockItemGrip can't handle button press also. We need somehow enable events either by packing into GtkEventBox or by changing property of floating_window. The patch Pavel attached makes handling of this situation more like in GtkHandleBox (i.e) with additional GdkWindow instead of GtkWindow. As I've understood, it was the way this thing was previously implemented. Federico: why have you decided to change the design to new? That requires size allocation handling and so on? Previous was was easier to my mind.
Created attachment 61867 [details] [review] Much simplier patch This patch enables button press handling, it's much easier and do the work. But it would be nice to make situation clearer. Either we should return to old GdkWindow handling or fix current.
If the patch works for you, commit it. Please test it very well with Evolution first (in the main shell window and in the mail message composer). The original design was broken: the undocked window was a child widget of its parent dock, but its allocation obviously was outside the parent's own allocation --- this doesn't make sense, and GTK+ does not support it. That's why I rewrote it to do its own handling as a separate widget.
Nikolay, did you have a chance to test it according to Federico's comments?
I've committed the patch, it works fine. Although I still think it would be better to return to original scheme. It's used in gdl also for example.
*** Bug 272022 has been marked as a duplicate of this bug. ***