After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732521 - HighContrast: use symbolic Adwaita icons
HighContrast: use symbolic Adwaita icons
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: HighContrast
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on: 732511
Blocks: 732484 734658 737990
 
 
Reported: 2014-06-30 21:28 UTC by Matthias Clasen
Modified: 2014-10-06 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
HC: use symbolic icons rather than a specific theme (1.17 KB, patch)
2014-08-04 13:34 UTC, Jakub Steiner 		none Details | Review
HC: use symbolic style icons (2.22 KB, patch)
2014-10-06 06:57 UTC, Jakub Steiner 		committed Details | Review

Description Matthias Clasen 2014-06-30 21:28:09 UTC 
This is really easy:

* { -gtk-icon-style: symbolic; }

We just need to make sure it works everywhere, and the symbolic icons in adwaita don't have gaps in their coverage. See the bug this blocks on.
Comment 1 Jakub Steiner 2014-08-04 13:34:55 UTC 
Created attachment 282437 [details] [review]
HC: use symbolic icons rather than a specific theme
Comment 2 Jakub Steiner 2014-08-04 14:40:41 UTC 
Patch to drop custom HC and use Adwaita for symbolic icons

http://jimmac.musichall.cz/stuff/0001-HC-use-symbolic-icons-for-HC.patch
Comment 3 Cosimo Cecchi 2014-08-04 22:00:11 UTC 
How is GTK2 going to work in HighContrast without the icons?
Comment 4 Cosimo Cecchi 2014-08-04 22:01:53 UTC 
Other than the concern above, the patches look good to me - there's probably even more cruft we could remove but that can be done in a later commit.
Comment 5 Jakub Steiner 2014-08-18 07:55:03 UTC 
(In reply to comment #3)
> How is GTK2 going to work in HighContrast without the icons?

That's a good question. Meaning I don't have an answer :(
Comment 6 Matthias Clasen 2014-09-29 20:43:46 UTC 
we can make gtk3 use the symbolic icons, regardless of what gtk2 does, as long as we still install the HighContrast icontheme, right ?
Comment 7 Matthias Clasen 2014-09-29 20:44:35 UTC 
Ah, I guess the shared gtk-icon-theme setting becomes an issue, here
Comment 8 Matthias Clasen 2014-09-29 20:47:14 UTC 
I guess we could put gtk-icon-theme=HighContrast into the gtk2 HighContrast gtkrc. Or alternatively, put gtk-icon-theme=Adwaita in the gtk3 HighContrast settings.ini, but I'd rather keep the ugly hack in gtk2 land.
Comment 9 Jakub Steiner 2014-10-06 06:57:03 UTC 
Created attachment 287806 [details] [review]
HC: use symbolic style icons

- don't remove the icon theme yet, keep it for gtk2
Comment 10 Jakub Steiner 2014-10-06 07:01:10 UTC 
Attachment 287806 [details] pushed as 51d0ef5 - HC: use symbolic style icons