After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732511 - missing symbolics
missing symbolics
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: symbolic
unspecified
Other Linux
: High normal
: ---
Assigned To: Jakub Steiner
adwaita-icon-theme maintainer(s)
Depends on:
Blocks: 732521
 
 
Reported: 2014-06-30 18:03 UTC by Matthias Clasen
Modified: 2015-02-10 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
symbolic icon for view-sort-ascending (1.09 KB, image/svg+xml)
2014-10-20 08:37 UTC, Caroline Henriksen
  Details
symbolic icon for view-sort-descending (1.09 KB, image/svg+xml)
2014-10-20 08:38 UTC, Caroline Henriksen
  Details
symbolic icon for gtk-select-color (2.28 KB, image/svg+xml)
2014-10-20 09:09 UTC, Caroline Henriksen
  Details
symbolic icon for gtk-select-font (2.12 KB, image/svg+xml)
2014-10-20 09:10 UTC, Caroline Henriksen
  Details
action and status icons missing form the HC set (53.73 KB, patch)
2014-10-20 11:09 UTC, Jakub Steiner
none Details | Review
more HC needs: folder-visitng, folder-open (12.62 KB, patch)
2014-10-20 11:14 UTC, Jakub Steiner
none Details | Review
HC needs: lock screen (2.60 KB, patch)
2014-10-20 11:16 UTC, Jakub Steiner
none Details | Review
HC needs: address-book-new (8.26 KB, patch)
2014-10-20 11:19 UTC, Jakub Steiner
none Details | Review
HC needs: application-exit (8.24 KB, patch)
2014-10-20 11:24 UTC, Jakub Steiner
none Details | Review
HC needs: appointment-new (3.54 KB, patch)
2014-10-20 12:08 UTC, Jakub Steiner
none Details | Review
HC needs: application-x-executable (8.47 KB, patch)
2014-10-20 12:13 UTC, Jakub Steiner
none Details | Review
HC needs: modem (9.06 KB, patch)
2014-10-20 12:20 UTC, Jakub Steiner
none Details | Review
HC needs: pda (7.92 KB, patch)
2014-10-20 12:21 UTC, Jakub Steiner
none Details | Review
HC needs: drive-harddisk-solidstate (19.14 KB, patch)
2014-10-20 12:31 UTC, Jakub Steiner
none Details | Review
HC needs: media-tape (7.33 KB, patch)
2014-10-20 12:36 UTC, Jakub Steiner
none Details | Review
HC needs: uninterruptible-power-supply (10.28 KB, patch)
2014-10-20 12:49 UTC, Jakub Steiner
none Details | Review
HC needs: document-print-preview (9.42 KB, patch)
2014-10-20 12:53 UTC, Jakub Steiner
none Details | Review
HC needs: document-revert + rtl (16.65 KB, patch)
2014-10-20 13:01 UTC, Jakub Steiner
none Details | Review
HC needs: edit-find-replace (10.30 KB, patch)
2014-10-20 13:05 UTC, Jakub Steiner
none Details | Review
HC needs: folder-new (8.23 KB, patch)
2014-10-20 13:09 UTC, Jakub Steiner
none Details | Review
HC needs: help-about, help-contents, help-faq (29.73 KB, patch)
2014-10-20 13:25 UTC, Jakub Steiner
none Details | Review
HC needs: folder-drag-accept (7.58 KB, patch)
2014-10-20 13:25 UTC, Jakub Steiner
none Details | Review
HC needs: tools-check-spelling (10.37 KB, patch)
2014-10-20 13:29 UTC, Jakub Steiner
none Details | Review
HC needs: image-loading (6.21 KB, patch)
2014-10-20 13:31 UTC, Jakub Steiner
none Details | Review

Description Matthias Clasen 2014-06-30 18:03:57 UTC
We're hoping to replace the HighContrast icon theme by Adwaita + icon-style: symbolic. Before doing so, we should make sure that the symbolic icon coverage in Adwaita has no major gaps, compared to the regular icons.

Here is a list of icons that have no symbolic variant, currently:

face-glasses
ac-adapter
battery
address-book-new
application-exit
appointment-new
contact-new
applications-accessories
applications-development
applications-internet
applications-office
applications-other
application-x-executable
other mimetypes
emblem-downloads
emblem-generic
emblem-mail
emblem-new
emblem-package
emblem-readonly
emblem-symbolic-link
emblem-unreadable
emblem-urgent
emblem-web
drive-harddisk-solidstate
drive-hardisk-system-solidstate
media-tape
modem
pda
phone-google-nexus-one
phone-htc-g1-white
phone-palm-pre
phone-samsung-galaxy-s
totem-tv
uninterruptible-power-supply
document-print-preview
document-revert
edit-find-replace
folder-new
gtk-apply
gtk-cancel
gtk-caps-lock-warning
gtk-color-picker
gtk-connect
gtk-convert
gtk-disconnect
gtk-dnd
gtk-dnd-multiple
gtk-edit
gtk-index
gtk-no
gtk-yes
gtk-orientation-landscape
gtk-orientation-portrait
gtk-orientation-reverse-landscape
gtk-orientation-reverse-portrait
gtk-page-setup
gtk-preferences
gtk-select-color
gtk-select-font
help-about
help-contents
help-faq
system-lock-screen
system-log-out
system-search
tools-check-spelling
view-sort-ascending
view-sort-descending
bluetooth-paired
folder-drag-accept
folder-open
folder-visiting
image-loading
mail-signed
mail-signed-verified
view-minimize
Comment 1 Jakub Steiner 2014-08-04 15:44:21 UTC
This is quite a mix of icon names. There's a couple of regressions if we flip the switch to Adwaita symbolic icons right now. 

* App icons.
  Now that we support symbolic icons, we can mandate apps to ship with symbolic variant of the app icon (large part of the current HC icon theme). Ie these should not be part of adwaita. 

* Action icons - these form the core of this bug report and need to be done.

* Specific device icons - things that are in gnome-icon-theme-extras. We focused on generic device in the main icon theme and symbolics make specific device icon seem even less crucial to have. We should probably move all these symbolics to -extras.

* Legacy stock names - I don't think it's desirable to bring back things that we removed from the gtk and Adwaita
Comment 2 Caroline Henriksen 2014-10-20 08:37:32 UTC
Created attachment 288892 [details]
symbolic icon for view-sort-ascending

Hi, 
I'm trying to work few some of the needed symbolic actions icons. I'm going to submit a few, let me know if these work out or need changes :)
Comment 3 Caroline Henriksen 2014-10-20 08:38:33 UTC
Created attachment 288893 [details]
symbolic icon for view-sort-descending
Comment 4 Caroline Henriksen 2014-10-20 09:09:43 UTC
Created attachment 288895 [details]
symbolic icon for gtk-select-color
Comment 5 Caroline Henriksen 2014-10-20 09:10:08 UTC
Created attachment 288897 [details]
symbolic icon for gtk-select-font
Comment 6 Jakub Steiner 2014-10-20 11:09:09 UTC
Created attachment 288912 [details] [review]
action and status icons missing form the HC set

color-select
font-select
view-sort-ascending
view-sort-descending
battery-symbolic
system-search
Comment 7 Jakub Steiner 2014-10-20 11:14:10 UTC
Created attachment 288914 [details] [review]
more HC needs: folder-visitng, folder-open
Comment 8 Jakub Steiner 2014-10-20 11:16:57 UTC
Created attachment 288915 [details] [review]
HC needs: lock screen
Comment 9 Jakub Steiner 2014-10-20 11:19:53 UTC
Created attachment 288916 [details] [review]
HC needs: address-book-new
Comment 10 Jakub Steiner 2014-10-20 11:24:37 UTC
Created attachment 288917 [details] [review]
HC needs: application-exit
Comment 11 Jakub Steiner 2014-10-20 12:08:39 UTC
Created attachment 288922 [details] [review]
HC needs: appointment-new
Comment 12 Jakub Steiner 2014-10-20 12:13:47 UTC
Created attachment 288923 [details] [review]
HC needs: application-x-executable
Comment 13 Jakub Steiner 2014-10-20 12:20:44 UTC
Created attachment 288925 [details] [review]
HC needs: modem
Comment 14 Jakub Steiner 2014-10-20 12:21:40 UTC
Created attachment 288926 [details] [review]
HC needs: pda
Comment 15 Jakub Steiner 2014-10-20 12:31:06 UTC
Created attachment 288928 [details] [review]
HC needs: drive-harddisk-solidstate
Comment 16 Jakub Steiner 2014-10-20 12:36:14 UTC
Created attachment 288931 [details] [review]
HC needs: media-tape
Comment 17 Jakub Steiner 2014-10-20 12:49:52 UTC
Created attachment 288932 [details] [review]
HC needs: uninterruptible-power-supply
Comment 18 Jakub Steiner 2014-10-20 12:53:59 UTC
Created attachment 288933 [details] [review]
HC needs: document-print-preview
Comment 19 Jakub Steiner 2014-10-20 13:01:12 UTC
Created attachment 288936 [details] [review]
HC needs: document-revert + rtl
Comment 20 Jakub Steiner 2014-10-20 13:05:06 UTC
Created attachment 288938 [details] [review]
HC needs: edit-find-replace
Comment 21 Jakub Steiner 2014-10-20 13:09:02 UTC
Created attachment 288939 [details] [review]
HC needs: folder-new
Comment 22 Jakub Steiner 2014-10-20 13:25:41 UTC
Created attachment 288942 [details] [review]
HC needs: help-about, help-contents, help-faq
Comment 23 Jakub Steiner 2014-10-20 13:25:56 UTC
Created attachment 288943 [details] [review]
HC needs: folder-drag-accept
Comment 24 Jakub Steiner 2014-10-20 13:29:27 UTC
Created attachment 288944 [details] [review]
HC needs: tools-check-spelling
Comment 25 Jakub Steiner 2014-10-20 13:31:47 UTC
Created attachment 288945 [details] [review]
HC needs: image-loading
Comment 26 Jakub Steiner 2014-10-20 13:33:34 UTC
Legacy things I skipped, as they aren't represented in the system any longer:

applications-accessories
applications-development
applications-internet
applications-office
applications-other
emblem-downloads
emblem-generic
emblem-mail
emblem-new
emblem-package
emblem-readonly
emblem-symbolic-link
emblem-unreadable
emblem-urgent
emblem-web
system-log-out

Specific device icons, which should just use a generic symbolic icon:

phone-google-nexus-one
phone-htc-g1-white
phone-palm-pre
phone-samsung-galaxy-s

Not sure what do with some of the gtk prefix items.
Comment 27 triniton 2014-10-29 16:05:46 UTC
Need symbolic icon for FM radio
Comment 28 André Klapper 2015-02-07 01:49:23 UTC
Can / should get the attached patches by jimmac from Oct 2014 get in?

Would like to avoid bitrot here.
Comment 29 Jakub Steiner 2015-02-10 10:34:32 UTC
(In reply to André Klapper from comment #28)
> Can / should get the attached patches by jimmac from Oct 2014 get in?

They should be all in. I guess I'll close this one as it contains a lot of unused old cruft and if there's exposed icons we're still missing, we'll deal with them individually.