After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734658 - Migrate High contrast icons to application
Migrate High contrast icons to application
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on: 732521
Blocks:
 
 
Reported: 2014-08-12 11:45 UTC by Pranav Kant
Modified: 2014-10-06 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icons: Migrate HighContrast icons to application (17.39 KB, patch)
2014-08-13 16:43 UTC, Pranav Kant 		none Details | Review
migrate highcontrast icons to application (8.94 KB, patch)
2014-08-14 06:23 UTC, Pranav Kant 		accepted-commit_now Details | Review
icons: Rename the hicolor source to make room for HighContrast icons (923.87 KB, patch)
2014-10-06 09:50 UTC, Debarshi Ray 		committed Details | Review
icons: Migrate HighContrast icons to application (9.05 KB, patch)
2014-10-06 09:51 UTC, Debarshi Ray 		committed Details | Review

Description Pranav Kant 2014-08-12 11:45:59 UTC 
gnome-documents' high contrast icons currently resides inside gnome-themes-standard. Move them to the application.
Comment 1 Pranav Kant 2014-08-13 16:43:42 UTC 
Created attachment 283316 [details] [review]
icons: Migrate HighContrast icons to application
Comment 2 Pranav Kant 2014-08-14 06:23:30 UTC 
Created attachment 283348 [details] [review]
migrate highcontrast icons to application

Simplified directory structure for icons.

Conversation from IRC :

23:33 < rishi> pranavk: I prefer to rename the icons.
23:36 < rishi> Changing our whole directory structure because some other module does it different does not sound like a convincing argument.
23:36 < rishi> I am sure every app does it slightly different.
23:43 < rishi> The other problem with separate directories is that it is hard to quickly go through the icons to check if they are ok. With a flat 
               directory, you can just walk through them with a viewer or nautilus.
Comment 3 Cosimo Cecchi 2014-08-14 18:01:29 UTC 
Review of attachment 283348 [details] [review]:

I think this looks good, but we have to wait for bug 732521 to be fixed first.
Comment 4 Cosimo Cecchi 2014-08-14 18:02:01 UTC 
Or alternatively you can just remove it manually from gnome-themes-standard first.
Comment 5 Debarshi Ray 2014-08-14 22:40:34 UTC 
Review of attachment 283348 [details] [review]:

::: data/icons/Makefile.am
@@ +20,1 @@
 	$(NULL)

Shouldn't we also update public_icons_themes? And what about the SVG source?
Comment 6 Debarshi Ray 2014-10-06 09:50:13 UTC 
Created attachment 287824 [details] [review]
icons: Rename the hicolor source to make room for HighContrast icons
Comment 7 Debarshi Ray 2014-10-06 09:50:57 UTC 
(In reply to comment #5)
> Review of attachment 283348 [details] [review]:
> 
> ::: data/icons/Makefile.am
> @@ +20,1 @@
>      $(NULL)
> 
> Shouldn't we also update public_icons_themes?

I took the liberty to update it.

> And what about the SVG source?

Can't find the SVG source for these high contrast icons. We can add them later.
Comment 8 Debarshi Ray 2014-10-06 09:51:27 UTC 
Created attachment 287825 [details] [review]
icons: Migrate HighContrast icons to application