After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737990 - icons: Use symbolics for HighContrast icons
icons: Use symbolics for HighContrast icons
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on: 732521
Blocks:
 
 
Reported: 2014-10-06 11:10 UTC by Debarshi Ray
Modified: 2015-01-14 17:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icons: Use symbolics for HighContrast icons (13.96 KB, patch)
2014-10-06 11:14 UTC, Debarshi Ray
none Details | Review
icons: Use symbolics for HighContrast icons (13.96 KB, patch)
2014-10-06 11:21 UTC, Debarshi Ray
none Details | Review
icons: Use symbolics for HighContrast icons (14.15 KB, patch)
2014-10-06 13:46 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2014-10-06 11:10:14 UTC
See bug 732521 for the background.

According to jimmac, the relevant symbolic is:
https://raw.githubusercontent.com/gnome-design-team/gnome-icons/master/apps-symbolic/adwaita/scalable/apps/documents-symbolic.svg
Comment 1 Debarshi Ray 2014-10-06 11:14:21 UTC
Created attachment 287835 [details] [review]
icons: Use symbolics for HighContrast icons
Comment 2 Debarshi Ray 2014-10-06 11:21:36 UTC
Created attachment 287837 [details] [review]
icons: Use symbolics for HighContrast icons
Comment 3 Debarshi Ray 2014-10-06 13:46:44 UTC
Created attachment 287853 [details] [review]
icons: Use symbolics for HighContrast icons

Jimmac pointed out that we should be installing these to Adwaita, not HighContrast.
Comment 4 Michael Catanzaro 2014-12-19 13:33:44 UTC
So, the high contrast icon is broken. How is this new method supposed to work?
Comment 5 Jakub Steiner 2015-01-13 14:58:16 UTC
The old style double stroked rendered PNGs for HC is a thing of the past. All you need to install to get the HC theme going is symbolic variants of icons (in this case, the app icon).

See bug #740447 for discussion on how the HC support has been implemented in the shell (and gtk)
Comment 6 Debarshi Ray 2015-01-13 15:38:57 UTC
From #gnome-design on GIMPNet:

15:02 <rishi> jimmac_: What makes you think that I am not using the tiny        
      little SVG? Honest question. It is as tiny as the gnome-books icon that   
      you added.
15:04 <jimmac_> rishi: i can't really parse base64 or whatever the garbage is,  
      but there's pngs in the patch
15:04 <jimmac_> aha, removal :)
15:04 <jimmac_> nevermind
15:05 <jimmac_> rishi: i would assume it goes to hicolor as well
15:05 <jimmac_> but that should "break it"
15:06 <rishi> I am quite sure that it goes to                                   
      /usr/share/icons/Adwaita/scalable/apps/...
Comment 7 Jakub Steiner 2015-01-14 12:22:09 UTC
Seems to be working fine when I tested it locally.
Comment 8 Michael Catanzaro 2015-01-14 17:02:22 UTC
I think the issue is that Documents went into rawhide with this change before the new gnome-shell did. At least, the reporter in the downstream bug reports he was using "GNOME 3.15.2" but the HC changes went into gnome-shell 3.15.3.

BTW I presume the old double stroke rendered PNGs are still supported. :)
Comment 9 Jakub Steiner 2015-01-14 17:09:17 UTC
Yes, legacy style HC theme with the rendered double stroke PNGs is still supported in shell 3.15