After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690920 - [PATCH] Support Automake 1.13
[PATCH] Support Automake 1.13
Status: RESOLVED DUPLICATE of bug 691352
Product: gnome-common
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-31 13:50 UTC by Kerrick Staley
Modified: 2013-01-08 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing the issue (1.40 KB, patch)
2012-12-31 13:50 UTC, Kerrick Staley 		none Details | Review

Description Kerrick Staley 2012-12-31 13:50:04 UTC 
Created attachment 232431 [details] [review]
Patch fixing the issue

When checking the Automake version in gnome-autogen.sh, only versions 1.9 through 1.12 are accepted, but Automake 1.13 was just released.

I don't know if the way the version check is currently implemented (see [1]) makes much sense: automake_progs is just a list of candidate executables to look at, so it doesn't need to be changed according to the required Automake
version - old versions will be rejected anyway. Also, automake_progs should include "automake" (so that the "automake" binary itself is checked) and perhaps "$AUTOMAKE" (allowing the Automake binary to be passed via an environment variable).

I've attached a patch fixing the issue.

[1] http://git.gnome.org/browse/gnome-common/tree/macros2/gnome-autogen.sh?id=4bb2a2450f67550ae761c75cb7ff2325bad54c8b#n346
Comment 1 Kerrick Staley 2012-12-31 13:54:10 UTC 
This is the same issue as

https://bugzilla.gnome.org/show_bug.cgi?id=690914

The code was just copied/pasted, I think.
Comment 2 Patrick Welche 2013-01-07 15:52:28 UTC 
The problem wouldn't have happened had the patch in 5 year old Bug 537772 been applied...
(Why accept "autoconf" but insist on refusing "automake")
Comment 3 Christian Persch 2013-01-08 17:49:58 UTC 

*** This bug has been marked as a duplicate of bug 691352 ***