GNOME Bugzilla – Bug 690914
Support Automake 1.13
Last modified: 2013-01-07 16:09:49 UTC
Created attachment 232424 [details] [review] Patch to support Automake 1.13 at-spi2-atk doesn't build with Automake 1.13 (which was just released), because it checks the Automake version number and only accepts values from 1.9 to 1.12. Automake 1.13 does work, however, so the check should be updated to accept Automake 1.13. A simple patch to do this is attached.
The patch I previously supplied fixes the problem in the obvious way, based on how the original code worked. However, I don't think the original code was really correct: the ac_progs list is just a list of candidate executables to look at, so it doesn't need to be changed according to the required Automake version - old versions will be rejected anyway. Also, ac_progs should include "$AUTOMAKE"(allowing the Automake binary to be passed via an environment variable) and "automake" (so that the "automake" binary itself is checked). I'll attach an alternative patch to implement this.
Err, I meant automake_progs, not ac_progs.
Created attachment 232425 [details] [review] Alternative (better) patch to support Automake 1.13
This is the same issue as
This is the same issue as https://bugzilla.gnome.org/show_bug.cgi?id=690920 The code was just copied/pasted, I think.
Comment on attachment 232425 [details] [review] Alternative (better) patch to support Automake 1.13 I'm fine with committing this (do you have commit access?), although I might eventually just pull a newer gnome-autogen.sh after 690920 is fixed.
Any way of avoiding gnome-autogen.sh and just using autoreconf? (Bug 537772 is five years old now - had the trivial patch to gnome-autogen.sh in it been applied, we wouldn't be here again...)
I've reworked the at-spi2-atk and pyatspi2 autogen.sh scripts to call autoreconf, as is done by at-spi2-core, so I think that this should be fixed now. Please re-open if not. Thanks.