After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691352 - gnome-autogen.sh: Add support for automake 1.13
gnome-autogen.sh: Add support for automake 1.13
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
: 690920 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-01-08 16:45 UTC by Raphael Kubo da Costa
Modified: 2013-01-15 18:10 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Proposed patch (2.21 KB, patch)
2013-01-08 16:45 UTC, Raphael Kubo da Costa 		accepted-commit_now Details | Review
Fix the issue in a more future-proof way by also adding "automake" to the list of checked binaries (1.14 KB, patch)
2013-01-13 20:28 UTC, Kerrick Staley 		none Details | Review

Description Raphael Kubo da Costa 2013-01-08 16:45:06 UTC 
Created attachment 232984 [details] [review]
Proposed patch

GNU automake 1.13 was released at the end of last December. The attached patch makes gnome-autogen.sh support the new version.
Comment 1 Christian Persch 2013-01-08 16:48:33 UTC 
Comment on attachment 232984 [details] [review]
Proposed patch

Thanks!
Comment 2 Raphael Kubo da Costa 2013-01-08 17:37:56 UTC 
Does the "accepted-commit_now" flag mean it is going to be committed automatically? FWIW, I'm not a GNOME committer.
Comment 3 Christian Persch 2013-01-08 17:49:29 UTC 
Committed. For future patches, please always use the git format-patch format, since that simplifies applying the patch. Thx!
Comment 4 Christian Persch 2013-01-08 17:49:58 UTC 
*** Bug 690920 has been marked as a duplicate of this bug. ***
Comment 5 Kerrick Staley 2013-01-08 21:08:07 UTC 
Could you please take a look at the patch described in Bug 690920 ([1])? I think that patch fixes this issue in a better (more future-proof) way.

[1] http://bugzilla-attachments.gnome.org/attachment.cgi?id=232431
Comment 6 Christian Persch 2013-01-08 22:03:47 UTC 
I did have a look at the other bug before taking this one's patch. I didn't like the other patch because it dropped automake 1.4 .. 1.8 support without explanation (well, 1.5..1.7 aren't relevant anymore, but 1.4 and 1.8 are).
Comment 7 Kerrick Staley 2013-01-09 16:21:47 UTC 
Oh, you're right: I thought 1.9 was the required minimum, but it looks like a lower version can be passed as an environment variable ([1]). You can add automake-1.8 and automake-1.4 to the list in the patch.

[1] http://git.gnome.org/browse/gnome-common/tree/macros2/gnome-autogen.sh#n10
Comment 8 Kerrick Staley 2013-01-13 20:27:36 UTC 
If anything, could you please at least add "automake" to the array that is passed to version_check? This will prevent breakage when a new Automake version is added in the future. See attached patch
Comment 9 Kerrick Staley 2013-01-13 20:28:38 UTC 
Created attachment 233401 [details] [review]
Fix the issue in a more future-proof way by also adding "automake" to the list of checked binaries
Comment 10 Patrick Welche 2013-01-15 18:10:09 UTC 
Your patch would find automake first, before checking for automake-1.12 etc., so as per my patch in five year old bug 537772, I would put automake after $automake_progs.

(One wonders why we are still processing bugs which could have been dealt with five years ago, but as this bug has already been set to fixed, I suppose this will continue.)