After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537772 - automake-1.10a rejected
automake-1.10a rejected
Status: RESOLVED OBSOLETE
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
: 600279 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-06-11 12:14 UTC by Patrick Welche
Modified: 2013-07-22 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix (1.09 KB, patch)
2008-06-11 12:17 UTC, Patrick Welche
none Details | Review
find automake (631 bytes, patch)
2009-04-30 09:56 UTC, Patrick Welche
none Details | Review

Description Patrick Welche 2008-06-11 12:14:37 UTC
Please describe the problem:
Say gnome-common is used with a package which requires at least automake-1.9, gnome-common will only look for files called "automake-1.9" or "automake-1.10". It will not look for "automake". If it were allowed to look for automake, it would do
the right thing and check the output of automake --version.

Steps to reproduce:
- just install automake-1.10a
- watch gnome-common not find automake

Actual results:


Expected results:


Does this happen every time?


Other information:
Index: macros2/gnome-autogen.sh
===================================================================
--- macros2/gnome-autogen.sh^I(revision 3913)
+++ macros2/gnome-autogen.sh^I(working copy)
@@ -317,7 +317,7 @@
     1.9*) automake_progs="automake-1.10 automake-1.9" ;;
     1.10*) automake_progs="automake-1.10" ;;
 esac
-version_check automake AUTOMAKE "$automake_progs" $REQUIRED_AUTOMAKE_VERSION \
+version_check automake AUTOMAKE "$automake_progs automake" $REQUIRED_AUTOMAKE_VERSION \
     "http://ftp.gnu.org/pub/gnu/automake/automake-$REQUIRED_AUTOMAKE_VERSION.tar.gz"
 ACLOCAL=`echo $AUTOMAKE | sed s/automake/aclocal/`
 
Index: README
===================================================================
--- README^I(revision 3913)
+++ README^I(working copy)
@@ -28,7 +28,7 @@
   it should also look in `$(datadir)/aclocal/gnome' and it will find all
   the macros.
 
-  The is a `gnome-skel' module in CVS that can be used as a starting point
+  There is a `gnome-skel' module in CVS that can be used as a starting point
   when writing a new GNOME Application that should be used outside CVS.
 
 February  4, 1999,
Comment 1 Patrick Welche 2008-06-11 12:17:51 UTC
Created attachment 112536 [details] [review]
fix

Same as in original bug report, but whitespace looked mangled.
It's the trivial fix (add automake to the list), plus a little typo fix.
Comment 2 Christian Persch 2008-06-21 13:29:08 UTC
I'm unable to find automake 1.10a. The latest version on the gnu ftp server is 1.10.1, which install a 'automake-1.10' binary; so the checks in gnome-common that look for automake-1.10 should find it.
Comment 3 Patrick Welche 2008-06-26 10:58:47 UTC
Development versions of automake have a letter after the version number. As you
check for the number anyway (development autoconf is found), why not allow "automake" as the name of the automake programme?
Comment 4 Patrick Welche 2009-04-30 09:56:19 UTC
Created attachment 133640 [details] [review]
find automake

Someone fixed the typo part of that old patch 3 days ago. Please make automake detection consistent with autoconf detection!
Comment 5 Christian Persch 2009-05-27 21:24:21 UTC
Is this still relevant? Automake 1.11 is out an supported by gnome-common now.
Comment 6 Patrick Welche 2010-02-10 17:33:30 UTC
Yes, I just tried to compile at-spi2-core, having discovered the git.gnome.org repository as opposed to the freedesktop one, and:

% sh autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... autoconf2.50: not found
not found.
  testing autoconf... found 2.65.35
checking for automake >= 1.9...
  testing automake-1.11... automake-1.11: not found
not found.
  testing automake-1.10... automake-1.10: not found
not found.
  testing automake-1.9... automake-1.9: not found
not found.
***Error***: You must have automake >= 1.9 installed
  to build Package.  Download the appropriate package for
  from your distribution or get the source tarball at
    http://ftp.gnu.org/pub/gnu/automake/automake-1.9.tar.gz

% automake --version
automake (GNU automake) 1.11a
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html
>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <tromey@redhat.com>
       and Alexandre Duret-Lutz <adl@gnu.org>.


It is become slightly irrelevant in that I try to use autoreconf -vif these days and ignore gnome-common. (Yes, in some sense I am volunteering to apply TLC to any configure.ac or Makefile.am file put my way...)
Comment 7 Christian Persch 2010-02-10 18:32:20 UTC
at-spi2-core's autogen.sh is broken. It looks like an older copy of gnome-autogen.sh; it should just *call* gnome-autogen.sh like any other module does. Please file a separate at-spi bug for this.
Comment 8 Patrick Welche 2010-02-11 08:32:19 UTC
I know at-spi2-core is broken and will file bugs accordingly.

You still seem to insist on ignoring the problem.

http://git.gnome.org/browse/gnome-common/tree/macros2/gnome-autogen.sh

is recent enough, right? Now, how will your most recent shiny version of gnome-autogen.sh recognise the fact that I have a very recent version of automake as in the listing above?

You check for autoconf rather than just autoconf-2.53, why don't you check for automake?

Why is this so hard to understand? (and feel free to send me autoconf/automake/libtool questions - I usually know how to fix them)
Comment 9 Javier Jardón (IRC: jjardon) 2013-07-19 11:12:49 UTC
*** Bug 600279 has been marked as a duplicate of this bug. ***
Comment 10 Javier Jardón (IRC: jjardon) 2013-07-22 08:38:57 UTC
Marked as obsolete as this is not needed anymore.

We do not check for automake manually, as we use autoreconf now. See bug #704544