After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 254503 - "New" dropdown menu on toolbar has wrong widget style
"New" dropdown menu on toolbar has wrong widget style
Status: RESOLVED DUPLICATE of bug 262210
Product: evolution
Classification: Applications
Component: general
2.4.x (obsolete)
Other All
: Normal trivial
: Future
Assigned To: Srinivasa Ragavan
Evolution QA team
: 257962 258410 265360 307776 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-02-18 03:08 UTC by Ed Catmur
Modified: 2006-06-18 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Button permanently shows in hovered state (15.37 KB, image/png)
2006-02-26 13:06 UTC, Jason Quigley 		Details

Description Ed Catmur 2004-02-18 03:08:41 UTC 
The "New" dropdown widget has a flat widget style; to integrate with the 
rest of the toolbar it should have a shaded widget style.

This bug is only visible when using a GTK theme that renders toolbars and
toolbar items differently from dialog backgrounds. An example is Amaranth.

The offending line is 488, e_combo_button_construct in 
widgets/misc/e-combo-button.c:

	gtk_button_set_relief (GTK_BUTTON (combo_button), GTK_RELIEF_NONE);

Blame is to Ettore Perazzoli:

2002-01-23  Ettore Perazzoli  <ettore@ximian.com>
	* e-combo-button.c: Remove member `separator' from
	`EComboButtonPrivate'.  New members `icon', `label'.
	(init): There shall be no separator no more.  Init `icon' and
	`label' to %NULL.
	(e_combo_button_construct): Set no relief.

I cannot see a good reason why this widget should have no relief. By 
default in GTK button widgets have relief.
Comment 1 Ed Catmur 2004-02-18 04:22:40 UTC 
Uh.. OK, I can - it gets ugly borders which are out of place on a 
toolbar widget.

It is however possible to do this in a better way - see Epiphany; their
EphyArrowToolButton widget epiphany/lib/widgets/ephy-arrow-toolbutton.c
implements a toolbar option menu button by subclassing GtkToolButton
and adding an arrow widget.
Comment 2 Gerardo Marin 2004-05-03 04:26:35 UTC 
*** bug 257962 has been marked as a duplicate of this bug. ***
Comment 3 Gerardo Marin 2004-05-16 02:32:27 UTC 
*** bug 258410 has been marked as a duplicate of this bug. ***
Comment 4 JP Rosevear 2004-12-18 10:29:33 UTC 
Moving to Rodney, I think there might be a dupe of this somewhere.
Comment 5 Rodney Dawes 2005-02-09 19:15:10 UTC 
*** bug 265360 has been marked as a duplicate of this bug. ***
Comment 6 Rodney Dawes 2005-02-21 19:04:46 UTC 
Fixed in CVS.
Comment 7 Dan Winship 2005-09-30 13:48:55 UTC 
The New button is broken with Clearlooks (the default GNOME 2.12 theme) in 2.4.0
Comment 8 André Klapper 2006-01-06 15:21:07 UTC 
assigning dobey's evo UI bugs to srag as he is the UI guy now. :-)
Comment 9 André Klapper 2006-01-09 01:37:34 UTC 
at least retargetting from a very ancient milestone to an ancient milestone ;-)
Comment 10 Jason Quigley 2006-02-26 13:06:25 UTC 
Created attachment 60151 [details]
Button permanently shows in hovered state

This is what the button looks like using Clearlooks Cairo. It looks quite out of place - especially when hovering over one of the other toolbar buttons.
Comment 11 André Klapper 2006-02-27 22:30:21 UTC 
*** Bug 307776 has been marked as a duplicate of this bug. ***
Comment 12 André Klapper 2006-05-31 13:53:06 UTC 
removing old target milestone.
Comment 13 André Klapper 2006-06-18 11:40:20 UTC 

*** This bug has been marked as a duplicate of 262210 ***