After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 775754 - Find an alternative to PhotosPreviewModel
Find an alternative to PhotosPreviewModel
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks: 690623
 
 
Reported: 2016-12-07 12:08 UTC by Debarshi Ray
Modified: 2016-12-08 06:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
base-manager, item-manager: Support sorting the GListModel (5.25 KB, patch)
2016-12-07 13:22 UTC, Debarshi Ray 		committed Details | Review
item-manager: Sort the child BaseManagers in decreasing order of mtime (1.83 KB, patch)
2016-12-07 13:23 UTC, Debarshi Ray 		committed Details | Review
base-manager: Add photos_base_manager_get_{next, previous}_object (6.05 KB, patch)
2016-12-07 13:23 UTC, Debarshi Ray 		committed Details | Review
Don't use PhotosPreviewModel to navigate in the PREVIEW mode (23.25 KB, patch)
2016-12-07 13:23 UTC, Debarshi Ray 		committed Details | Review
view-container: Remove unused methods (2.78 KB, patch)
2016-12-07 13:24 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2016-12-07 12:08:00 UTC 
We are trying to stop using a GtkTreeModel/GtkIconView to show the thumbnail grid because we want to use a GtkFlowBox (bug 690623). This means we should find an alternative to PhotosPreviewModel for navigating within the PREVIEW mode because we are going to stop using PhotosViewModel.
Comment 1 Debarshi Ray 2016-12-07 13:22:59 UTC 
Created attachment 341544 [details] [review]
base-manager, item-manager: Support sorting the GListModel
Comment 2 Debarshi Ray 2016-12-07 13:23:19 UTC 
Created attachment 341546 [details] [review]
item-manager: Sort the child BaseManagers in decreasing order of mtime
Comment 3 Debarshi Ray 2016-12-07 13:23:38 UTC 
Created attachment 341547 [details] [review]
base-manager: Add photos_base_manager_get_{next, previous}_object
Comment 4 Debarshi Ray 2016-12-07 13:23:54 UTC 
Created attachment 341549 [details] [review]
Don't use PhotosPreviewModel to navigate in the PREVIEW mode
Comment 5 Debarshi Ray 2016-12-07 13:24:08 UTC 
Created attachment 341550 [details] [review]
view-container: Remove unused methods
Comment 6 Debarshi Ray 2016-12-08 06:50:56 UTC 
Pushed these to master. Let me know if something is wrong.