After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 97414 - gtkaccellabel: s/seperator/separator/
gtkaccellabel: s/seperator/separator/
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkLabel
2.90.x
Other All
: Normal normal
: 3.0
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 347771
 
 
Reported: 2002-11-01 16:43 UTC by Morten Welinder
Modified: 2017-08-04 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove unused class member (1.13 KB, patch)
2010-05-19 18:17 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Remove unused class member.v2 (1.71 KB, patch)
2010-05-20 00:42 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Morten Welinder 2002-11-01 16:43:38 UTC 
You mean separator, not seperator.

../gtk+/gtk/gtkaccellabel.c:  class->accel_seperator = g_strdup (" / ");
../gtk+/gtk/gtkaccellabel.c:      g_string_append (gstring, gstring->len ?
class->accel_seperator : "   ");
../gtk+/gtk/gtkaccellabel.h:  gchar             *accel_seperator;
Comment 1 Owen Taylor 2002-11-01 17:41:28 UTC 
Since it is in the class, it is presumably meant as API,
even if I can't imagine why you would want to change it.
Thus it can't change until we break API compatibility.

Actually, looking at the code, I don't think the accel-separator
will ever be displayed any more; I think it might be there
for the old pre-2.0 feature of being able to display the
signal name in the accelerator label, which went away when
we switched over to using closures.
Comment 2 Javier Jardón (IRC: jjardon) 2010-05-19 18:17:49 UTC 
Created attachment 161479 [details] [review]
Remove unused class member
Comment 3 Javier Jardón (IRC: jjardon) 2010-05-20 00:42:42 UTC 
Created attachment 161509 [details] [review]
Remove unused class member.v2

I think that this can be applied in the current master (future 3.0) branch.
Comment 4 Matthias Clasen 2010-08-10 01:50:27 UTC 
Review of attachment 161509 [details] [review]:

Yes, looks fine to me.
Comment 5 Javier Jardón (IRC: jjardon) 2010-08-10 02:19:14 UTC 
Comment on attachment 161509 [details] [review]
Remove unused class member.v2

commit f760538f17673c5bd7fec792be2f1abf8148fc32
Comment 6 Javier Jardón (IRC: jjardon) 2010-08-10 02:19:23 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.