After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 96631 - Support RTL flipping for option menus
Support RTL flipping for option menus
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.1.x
Other other
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 76219
 
 
Reported: 2002-10-23 18:10 UTC by Matthias Clasen
Modified: 2011-02-04 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.58 KB, patch)
2002-10-23 22:31 UTC, Matthias Clasen
none Details | Review
Here is the corresponding patch for gtk-engines (1.19 KB, patch)
2002-10-29 22:23 UTC, Matthias Clasen
none Details | Review
wrong fix (717 bytes, patch)
2002-11-05 23:46 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2002-10-23 18:10:36 UTC
the arrow should be on the other side in RTL mode.
Comment 1 Owen Taylor 2002-10-23 19:08:17 UTC
Moving all the RTL flipping bugs to the 2.4.0 milestone; in some
cases the changes should be easy to do. (GtkPaned comes to mind)
In those cases, we can move the bugs back to 2.2.0 if patches occur.
Comment 2 Matthias Clasen 2002-10-23 22:30:56 UTC
This one was relatively easy as well, but it turns out that a paint
function has to be changed (gtk_paint_box (..."optionmenu"...)). I
guess that means that existing theme engines will need some RTL love
after this change, but thats probably ok.
Comment 3 Matthias Clasen 2002-10-23 22:31:33 UTC
Created attachment 11795 [details] [review]
patch
Comment 4 Matthias Clasen 2002-10-29 22:23:52 UTC
Created attachment 11902 [details] [review]
Here is the corresponding patch for gtk-engines
Comment 5 Owen Taylor 2002-11-01 23:12:07 UTC
I very much doubt that current theme engines are RTL-clean
even for the current flipping, so I don't mind adding a bit
more.

Patch looks fine.
Comment 6 Owen Taylor 2002-11-02 04:11:57 UTC
Hmm, drawing seems to be a bit misaligned with the default theme.
Comment 7 Matthias Clasen 2002-11-05 23:45:54 UTC
This is because the default indicator_spacing is asymmetric. It has
left == 7 and right == 5. Seeing that almost all of gtkoptionmenu.c
depends only on the sum of the two, I tried to change them to 6 and 6,
but that 
unfortunately causes both rtl and ltr to come out slightly misaligned. 

The following "obviously wrong" patch looks ok with the default spacing.
Comment 8 Matthias Clasen 2002-11-05 23:46:34 UTC
Created attachment 12080 [details] [review]
wrong fix
Comment 9 Owen Taylor 2002-11-07 23:11:13 UTC
Chunky seems reasonable to me ... it's a little funky to flip
the indicator spacing, but clearly right since the indicator
spacing is defined in terms of the relationship of the indicator
to other elements of the optionmenu.
Comment 10 Owen Taylor 2002-11-07 23:45:10 UTC
In case it isn't clear "Chunky" was meant to be "Patch".
I think it's some sort of bizarre blend of the "funky"
that I used later in the sentence and "Chunk" as a 
synonym for "Patch".
Comment 11 Matthias Clasen 2002-11-08 22:00:09 UTC
Committed the chunky to HEAD now...