After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795835 - cerbero: omx plugin gets listed in android plugins.mk
cerbero: omx plugin gets listed in android plugins.mk
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal blocker
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-05 14:01 UTC by Jan Schmidt
Modified: 2018-05-05 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't include gst-omx plugin into Android and iOS list (1.31 KB, patch)
2018-05-05 14:02 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Jan Schmidt 2018-05-05 14:01:41 UTC 
https://bugzilla.gnome.org/show_bug.cgi?id=795526 added gst-omx to the cerbero build, but it unconditionally lists the gstomx plugin into the files_plugins_codecs variable.

The list_gstreamer_1_0_plugins_by_category() function is used for iOS and Android to generate the plugins list, and other recipes only report the plugins being built for the current target platform.

An ideal fix is to enhance cerbero to be able to actually generate only the list of plugin files for the current target.
Comment 1 Nicolas Dufresne (ndufresne) 2018-05-05 14:02:11 UTC 
Created attachment 371712 [details] [review]
Don't include gst-omx plugin into Android and iOS list

The list_gstreamer_1_0_plugins_by_category() is only used for these two
platforms and these platforms will never include OMX. As OMX is generic
without being generic, it would be complicated to do the per platform
filter correctly.
Comment 2 Matthew Waters (ystreet00) 2018-05-05 14:05:54 UTC 
The other option is to move the omx plugins to the platform specific list, platform_files_plugins_codecs for linux-only.
Comment 3 Nicolas Dufresne (ndufresne) 2018-05-05 14:07:36 UTC 
Attachment 371712 [details] pushed as f2358c0 - Don't include gst-omx plugin into Android and iOS list