After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795526 - recipes: Add new recipe gst-omx
recipes: Add new recipe gst-omx
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 795584
 
 
Reported: 2018-04-24 23:25 UTC by Omar Akkila
Modified: 2018-04-26 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
recipes: new gst-omx recipe (4.87 KB, patch)
2018-04-24 23:27 UTC, Omar Akkila 		none Details | Review
recipes: new recipe gst-omx (3.78 KB, patch)
2018-04-25 22:24 UTC, Omar Akkila 		committed Details | Review

Description Omar Akkila 2018-04-24 23:25:58 UTC 
.
Comment 1 Omar Akkila 2018-04-24 23:27:04 UTC 
Created attachment 371354 [details] [review]
recipes: new gst-omx recipe
Comment 2 Olivier Crête 2018-04-25 12:41:03 UTC 
Review of attachment 371354 [details] [review]:

I would put gst-omx into the codecs package instead of it's own package.

::: recipes/gst-omx-1.0.recipe
@@ +18,3 @@
+        self.append_env['CFLAGS'] = " -Wno-error "
+        self.append_env['CXXFLAGS'] = " -Wno-error "
+        self.append_env['CPPFLAGS'] = " -Wno-error "

Those shouldn't be needed, the -Werror should only be for pre-releases

@@ +24,3 @@
+
+        if self.config.variants.rpi:
+            eq = '=' if self.config.sysroot else ''

I think you can put the '=' unconditionally
Comment 3 Omar Akkila 2018-04-25 22:24:50 UTC 
Created attachment 371405 [details] [review]
recipes: new recipe gst-omx
Comment 4 Olivier Crête 2018-04-26 13:27:33 UTC 
Merged!

Attachment 371405 [details] pushed as 238067c - recipes: new recipe gst-omx