GNOME Bugzilla – Bug 795301
meson: follow meson_options convention
Last modified: 2018-04-17 07:38:18 UTC
Following the new conventions, on the options we should not add with, enable or disable. So we should change disable_introspection to just introspection and enable_docs to just docs
Created attachment 371010 [details] [review] meson: follow option convetions
By the way, I think we are at the point where we could remove autotools and the vs projects in master
Review of attachment 371010 [details] [review]: LGTM
(In reply to Ignacio Casal Quinteiro (nacho) from comment #2) > By the way, I think we are at the point where we could remove autotools Yes, I would like to remove autotools in this cycle. Will try to book some time today. > and the vs projects in master Sorry if the question is silly: for VS do you mean Visual Studio projects? If that is the case, I will rely that decision on Chun-wei Fan, that is the one maintaining that build system on ATK (CCing him)
Attachment 371010 [details] pushed as 67ffa20 - meson: follow option convetions
Yes, I meant the visual studio projects. Sure we can let Fan decide about them although it's been done also for other projects.
(In reply to Ignacio Casal Quinteiro (nacho) from comment #6) > Yes, I meant the visual studio projects. Sure we can let Fan decide about > them although it's been done also for other projects. FWIW: Bug 795315 with a patch to remove autotools, tested on Linux, just created. It also CCes Chun-Wei Fan to check if it is ok for MSVC.