After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795301 - meson: follow meson_options convention
meson: follow meson_options convention
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-04-16 14:16 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2018-04-17 07:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: follow option convetions (1.86 KB, patch)
2018-04-17 06:45 UTC, Ignacio Casal Quinteiro (nacho)
committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2018-04-16 14:16:03 UTC
Following the new conventions, on the options we should not add with, enable or disable. So we should change disable_introspection to just introspection and enable_docs to just docs
Comment 1 Ignacio Casal Quinteiro (nacho) 2018-04-17 06:45:19 UTC
Created attachment 371010 [details] [review]
meson: follow option convetions
Comment 2 Ignacio Casal Quinteiro (nacho) 2018-04-17 06:46:24 UTC
By the way, I think we are at the point where we could remove autotools and the vs projects in master
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-17 06:58:48 UTC
Review of attachment 371010 [details] [review]:

LGTM
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-17 07:03:41 UTC
(In reply to Ignacio Casal Quinteiro (nacho) from comment #2)
> By the way, I think we are at the point where we could remove autotools

Yes, I would like to remove autotools in this cycle. Will try to book some time today.

> and the vs projects in master

Sorry if the question is silly: for VS do you mean Visual Studio projects? If that is the case, I will rely that decision on Chun-wei Fan, that is the one maintaining that build system on ATK (CCing him)
Comment 5 Ignacio Casal Quinteiro (nacho) 2018-04-17 07:13:16 UTC
Attachment 371010 [details] pushed as 67ffa20 - meson: follow option convetions
Comment 6 Ignacio Casal Quinteiro (nacho) 2018-04-17 07:14:20 UTC
Yes, I meant the visual studio projects. Sure we can let Fan decide about them although it's been done also for other projects.
Comment 7 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-17 07:38:18 UTC
(In reply to Ignacio Casal Quinteiro (nacho) from comment #6)
> Yes, I meant the visual studio projects. Sure we can let Fan decide about
> them although it's been done also for other projects.

FWIW: Bug 795315 with a patch to remove autotools, tested on Linux, just created. It also CCes Chun-Wei Fan to check if it is ok for MSVC.