After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795315 - Remove autotools support
Remove autotools support
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-04-17 07:36 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2018-04-24 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove autotools configuration files (20.32 KB, patch)
2018-04-17 07:36 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
none Details | Review
Remove win32 configuration files (20.38 KB, patch)
2018-04-17 09:49 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
none Details | Review
Updated version of "Remove autotools configuration" (24.12 KB, patch)
2018-04-17 10:48 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
committed Details | Review
Remove win32 configuration files + config.h.win32 (118.46 KB, patch)
2018-04-23 14:52 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
committed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-17 07:36:01 UTC
Created attachment 371011 [details] [review]
Remove autotools configuration files

The reason to create this bug instead of just pushing it is in order to know if this affects MSVC builds, and if it can be expanded to remove some of the configuration files at the win32 directory.

CCing Chun-wei fan.
Comment 1 Fan, Chun-wei 2018-04-17 07:50:52 UTC
Hi Alejandro,

I think it is ok to me to remove the win32/ subdir as well, since I have been using Meson to build ATK with Visual Studio with Ninja at least which works quite alright.

The items in win32/ should still work, but I think we should direct people to use Meson, and focus maintenance efforts on the build system on Meson

With blessings, and cheers!
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-17 09:49:08 UTC
Created attachment 371024 [details] [review]
Remove win32 configuration files

(In reply to Fan, Chun-wei from comment #1)
> Hi Alejandro,
> 
> I think it is ok to me to remove the win32/ subdir as well, since I have
> been using Meson to build ATK with Visual Studio with Ninja at least which
> works quite alright.
> 
> The items in win32/ should still work, but I think we should direct people
> to use Meson, and focus maintenance efforts on the build system on Meson
> 
> With blessings, and cheers!

Ok, so then, could you take a look to this patch and confirm that it is ok to push?
Comment 3 Piotr Drąg 2018-04-17 10:34:29 UTC
Review of attachment 371011 [details] [review]:

Please remove po/Makevars as well.
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-17 10:48:47 UTC
Created attachment 371029 [details] [review]
Updated version of "Remove autotools configuration"

Removes too po/Makevars
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-23 14:24:03 UTC
Chun-wei Fan: ping. Could you take a look to the "Remove win32 configuration files" and confirm if it is ok to apply it?
Comment 6 Ignacio Casal Quinteiro (nacho) 2018-04-23 14:31:55 UTC
I think you might need to remove config.h.win32? Fan?
Comment 7 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-23 14:52:57 UTC
Created attachment 371278 [details] [review]
Remove win32 configuration files + config.h.win32

> I think you might need to remove config.h.win32? Fan?

Meanwhile we wait him to confirm, uploading a version with that file removed too.
Comment 8 Fan, Chun-wei 2018-04-24 10:36:56 UTC
Hi Alejandro,

Sorry for the delay... config.h.win32(.in) does need to get removed as well.

I think the patch removal of the Visual Studio projects and associated stuff look good to me (It seems to me that only the last 2 patches are relevant-am I correct here?)

With blessings, and cheers!
Comment 9 Alejandro Piñeiro Iglesias (IRC: infapi00) 2018-04-24 11:23:40 UTC
(In reply to Fan, Chun-wei from comment #8)
> Hi Alejandro,
> 
> Sorry for the delay... config.h.win32(.in) does need to get removed as well.
> 
> I think the patch removal of the Visual Studio projects and associated stuff
> look good to me (It seems to me that only the last 2 patches are relevant-am
> I correct here?)
> 
> With blessings, and cheers!

Thanks for confirming. I have just committed those two patches. If I have time I think that I would need to update jhbuild moduleset.

But this bug is fixed. Thanks everybody.