After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795046 - Add Gray theme back to GIMP
Add Gray theme back to GIMP
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.10.0-RC1
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2018-04-07 06:01 UTC by Elle Stone
Modified: 2018-04-10 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Gray theme back to GIMP (164.72 KB, patch)
2018-04-07 06:01 UTC, Elle Stone
none Details | Review

Description Elle Stone 2018-04-07 06:01:20 UTC
Created attachment 370626 [details] [review]
Add Gray theme back to GIMP

After updating GIMP from git this morning, it seems the only remaining themes are Dark and Light. 

The attached patch restores the Middle Gray (L=50) theme.

Too much contrast on the screen causes eye strain. The Dark (L=23) is not easy to look at. The Light (L=88) theme is better, but still is no substitute for a middel gray theme.

Middle gray is very easy on the eyes and - equally as important - allows to judge image colors against middle gray, with completely unobtrusive theme tonalities and colors.
Comment 1 Jehan 2018-04-07 12:09:04 UTC
Is it the previously available theme? If so, changes we get it back are low because it had so many bugs and nobody to maintain it.
We'll see with the new theme maintainer (Ville/drc) if he is ok to make a new gray theme instead.
Comment 2 Elle Stone 2018-04-07 14:16:17 UTC
(In reply to Jehan from comment #1)
> Is it the previously available theme? If so, changes we get it back are low
> because it had so many bugs and nobody to maintain it.
> We'll see with the new theme maintainer (Ville/drc) if he is ok to make a
> new gray theme instead.

There are minimal differences between the middle Gray and Light themes other than the actual theme colors. So what specific bugs are in the Gray theme? 

There was at one point a problem in the Gray Theme with the highlighted item disappearing into the highlighting. A bug report was filed and this was fixed: 
https://bugzilla.gnome.org/show_bug.cgi?id=785080

I asked about the missing Gray theme on IRC yesterday morning, and some people seemed to indicating that the "buggy" themes were the Dark and Darker themes, not the Gray theme.

Once you take into consideration "color appearance" issues, the importance of a middle Gray theme is obvious. If the image fills most of the screen, the theme becomes a significant part of the image surround. The most neutral possible image surround is precisely middle gray.

Quoting from RawTherapee's dev for the CIECAM02 module (https://discuss.pixls.us/t/rawtherapees-ciecam02-module/4679/30):

"For me, if we want not to have CAM problem, the best solution is to have a theme surround about Yb=18 (as in my very old Photoshop). In another word with a grey luminance L=50 :slight_smile:"

Als see this post by Steve Kinney: http://gimp.1065349.n5.nabble.com/Dark-Theme-for-GIMP-tt38594.html#a38601

And this thread: https://mail.gnome.org/archives/gimp-gui-list/2015-December/msg00047.html

I did try removing *all* possible differences between the new Light theme and the old Gray theme in the gtkrc file - other than the actual colors, and the net result was a recreation of the "highlighted lines of text disappear into the highlight color" bug. But as I already noted, the old Gray theme does not have this problem.
Comment 3 jose americo gobbo 2018-04-07 16:24:28 UTC
(In reply to Elle Stone from comment #2)

> I did try removing *all* possible differences between the new Light theme
> and the old Gray theme in the gtkrc file - other than the actual colors, and
> the net result was a recreation of the "highlighted lines of text disappear
> into the highlight color" bug. But as I already noted, the old Gray theme
> does not have this problem.

A good motif to recover the old Gray Theme.
Comment 4 Øyvind Kolås (pippin) 2018-04-09 22:17:16 UTC
commit 54ca0a7f68332b3a1195343bb9c6719dbf4579ec (HEAD -> master)
Author: Elle Stone <ellestone@ninedegreesbelow.com>
Date:   Sat Apr 7 01:46:07 2018 -0400

    Add Gray theme back to GIMP
    
    that was removed by commit 7aecc90e10aa48bcbc73a5199c9591c16ff5b022