After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785080 - in some places the 02-Gray Theme lacks foreground-background contrast
in some places the 02-Gray Theme lacks foreground-background contrast
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2017-07-18 17:00 UTC by Elle Stone
Modified: 2017-12-10 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the Image Import dialog showing lack of contrast. (104.35 KB, image/jpeg)
2017-07-18 17:00 UTC, Elle Stone
Details

Description Elle Stone 2017-07-18 17:00:12 UTC
Created attachment 355864 [details]
Screenshot of the Image Import dialog showing lack of contrast.

In at least one place the 02-Gray Theme lacks foreground-background contrast, specifically in "Preferences/Image Import" for selecting a raw file import plug-in. 

As shown in the attached screenshot, this lack of contrast makes it impossible to see which raw file import plug-in is actually chosen. For a long time I thought GIMP wasn't even detecting the darktable plug-in, but the real problem is the lack of contrast between the highlight box color and the text color.

There is a similar issue in some of the dialogs, where I think there is supposed to be a box, but there's just text (but the text is enough to show where to click).
Comment 1 Jehan 2017-07-19 11:22:53 UTC
Apparently someone will probably write us new themes and we will get rid of the current new ones because they are just too messy to debug.

I keep this opened just in case, but this may get obsolete (hopefully soon).
Let's wait and see.
Comment 2 Massimo 2017-12-02 08:43:59 UTC
For this particular problem it is possible to add here:

https://git.gnome.org/browse/gimp/tree/themes/Gray/gtkrc#n515

a line like that with GtkTreeView replaced by GimpPlugInView


I think that GimpPlugInView was developed after the introduction
of these themes.

This would only affect that place that is the only one where it is
used (according to grep).

I do not use this theme and so to fix the "similar issue in some
of the dialogs" it would be important to have an example
Comment 3 Jehan 2017-12-02 15:11:26 UTC
As usual, Massimo, thanks. I pushed the fix as below.

Elle > could you list all the other dialogs where you saw similar contrast issue with this theme? Thanks!

commit 32d575b64f6bb453d39b4dfb5350192630c5b1ad (HEAD -> master, origin/master, origin/HEAD)
Author: Jehan <jehan@girinstud.io>
Date:   Sat Dec 2 16:09:03 2017 +0100

    Bug 785080 - 02-Gray Theme lacks foreground-background contrast.
    
    Thanks to Massimo for the solution!

 themes/Gray/gtkrc | 1 +
 1 file changed, 1 insertion(+)
Comment 4 Elle Stone 2017-12-10 16:45:07 UTC
(In reply to Jehan from comment #3)
> As usual, Massimo, thanks. I pushed the fix as below.
> 
> Elle > could you list all the other dialogs where you saw similar contrast
> issue with this theme? Thanks!
> 
> commit 32d575b64f6bb453d39b4dfb5350192630c5b1ad (HEAD -> master,
> origin/master, origin/HEAD)
> Author: Jehan <jehan@girinstud.io>
> Date:   Sat Dec 2 16:09:03 2017 +0100
> 
>     Bug 785080 - 02-Gray Theme lacks foreground-background contrast.
>     
>     Thanks to Massimo for the solution!
> 
>  themes/Gray/gtkrc | 1 +
>  1 file changed, 1 insertion(+)

Hmm, I've been using default GIMP for several days now (updated almost every day including this morning), and haven't noticed any problem with foreground-background contrast in the dialogs. I think the specific other dialog might have been one of the workshop dialogs in Tools/GEGL operation. But I just checked all of those dialogs and didn't see any problem with contrast. I also checked some other dialogs more or less randomly, and didn't see any contrast issues. And I checked all the Windows that I normally have open in the Toolbox, and didn't see any contrast problems in any of the sliders.

So maybe this bug report can be closed, and if I find a particular slider that does have a contrast problem, I'll reopen the bug report?

Oh, Massimo's solution did of course fix the problem with the image import raw plug-in dialog.
Comment 5 Jehan 2017-12-10 16:48:38 UTC
> So maybe this bug report can be closed, and if I find a particular slider that does have a contrast problem, I'll reopen the bug report?

Let's do this. You can either reopen this one or create a new one.