After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794721 - CRITICAL converting image precision
CRITICAL converting image precision
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.10.0-RC1
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
: 795291 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-03-27 13:03 UTC by Massimo
Modified: 2018-04-16 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Massimo 2018-03-27 13:03:49 UTC 
Here the 'progress' argument is overwritten by the queue object address:

https://git.gnome.org/browse/gimp/tree/app/core/gimpimage-convert-precision.c#n115

and here:

https://git.gnome.org/browse/gimp/tree/app/core/gimpimage-convert-precision.c#n234

it is used just after queue has been unreffed. The result is:

(gimp-2.10:9): Gimp-Core-CRITICAL **: 14:49:15.312: gimp_progress_end: assertion 'GIMP_IS_PROGRESS (progress)' failed

Don't know if the progress_end call is now useless or if the value passed as argument should be used to call gimp_progress_end();
Comment 1 Ell 2018-03-27 13:41:41 UTC 
Thanks, I must be blind :)  Fixed in master:

commit cf658f64b5e91e1c3c741e0188b2505e6c970447
Author: Ell <ell_se@yahoo.com>
Date:   Tue Mar 27 09:34:42 2018 -0400

    Bug 794721 - CRITICAL converting image precision
    
    In gimp_image_convert_precision(), don't overwrite the 'progress'
    parameter with the object queue, since we need to call
    gimp_progress_end() on it at the end of the process.

 app/core/gimpimage-convert-precision.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 2 Ell 2018-04-16 12:18:07 UTC 
*** Bug 795291 has been marked as a duplicate of this bug. ***