Created attachment 369184 [details] [review]
Fix - part 1

Fix to the above-mentioned bug

Apparently bold was only disabled for faux-bold.

Created attachment 369186 [details] [review]
Fix, v2

Hmmm, I was about to ask if we have a faulty faux bold, but then suddenly realized that it's my previous patch that breaks it :)

Due to the removal of the "&& other_condition" its auto type is no longer bool but int in the previous patch, receiving the value of VTE_ATTR_BOLD which happens to be 32, so later faux bold extends the background rectangle by 32 pixels. (That implicit bool -> int conversion over there is also a bit ugly.)

Maybe it's time to finally remove faux bold (bug 756010, bug 789534 comments 2-4). Probably not a good idea right before the feature freeze, but we could do it early in the 0-53 days.

Created attachment 369191 [details] [review]
int vs bool cleanup

> Created attachment 369186 [details] [review] [review]
> Fix, v2

Alternatively, we could just use "bold" rather than "attr & VTE_ATTR_BOLD" at the very bottom of this method. Christian, pick one please :)

Comment on attachment 369191 [details] [review]
int vs bool cleanup

I fixed the bug in a different way, but this cleanup is still good. Thanks!