After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756010 - remove faux bold
remove faux bold
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on: 682692
Blocks:
 
 
Reported: 2015-10-03 09:38 UTC by Christian Persch
Modified: 2018-03-21 20:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove faux bold (2.37 KB, patch)
2018-03-21 13:07 UTC, Egmont Koblinger 		committed Details | Review

Description Christian Persch 2015-10-03 09:38:20 UTC 
If the font doesn't have bold, we do the overdrawing which draws one pixel to the right outside the cell. We should just remove that and either require the font to have bold, or just not draw bold if the font doesn't have bold.
Comment 1 Egmont Koblinger 2018-03-21 13:07:20 UTC 
Created attachment 369957 [details] [review]
Remove faux bold

How to test:

Pick a font that doesn't have bold counterpart, maybe because it's already bold:
  ./src/app/vte-2.91 -f 'Monospace Bold 10'

Produce some bold text, it's no longer even bolder.

This is the second of two patches, the first one is in bug 682692.
Comment 2 Christian Persch 2018-03-21 18:46:52 UTC 
Comment on attachment 369957 [details] [review]
Remove faux bold

Master only, please. Thanks for the patch!
Comment 3 Egmont Koblinger 2018-03-21 20:27:45 UTC 
> Master only, please.

Obviously! :)

Submitted.