After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793818 - pressing 'Del' once deletes more than one picture
pressing 'Del' once deletes more than one picture
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: library-mode
0.27.x
Other Linux
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
: 794305 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-02-25 21:57 UTC by Richard B. Kreckel
Modified: 2018-03-13 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set restore point after trashing photo (1.28 KB, patch)
2018-02-26 17:17 UTC, Jens Georg
none Details | Review
Save selection before setting the restore point (1.26 KB, patch)
2018-02-26 17:57 UTC, Jens Georg
committed Details | Review

Description Richard B. Kreckel 2018-02-25 21:57:11 UTC
I've now repeatedly observed that pressing the 'Del' key on a picture within an event moves more pictures than the selected one into the Trash. (They're all sitting in Trash and can be Restored, but this is quite disrupting to the workflow.)
Comment 1 Richard B. Kreckel 2018-02-26 08:51:48 UTC
Tried a couple more times: two pictures are actually moved to trash every time I press 'Del'. This happens in overview mode; when the picture is fullscreen and I press 'Del', only the current picture gets deleted.

I'm using current git master/HEAD.
Comment 2 Jens Georg 2018-02-26 16:48:30 UTC
Seems to be specifically to using the key. Works as expected when using the context menu
Comment 3 Jens Georg 2018-02-26 17:17:21 UTC
Created attachment 368953 [details] [review]
Set restore point after trashing photo

Setting the restore point will add the restore point to the selection,
thus effectively removing it as well.
Comment 4 Jens Georg 2018-02-26 17:18:57 UTC
Unfortunately, that would be undoing the fix for bug 786531
Comment 5 Jens Georg 2018-02-26 17:57:53 UTC
Created attachment 368957 [details] [review]
Save selection before setting the restore point

With the fix for bug 786531, setting the restore point before executing
the job would add the restore point to the list of selected items.
Comment 6 Richard B. Kreckel 2018-02-26 18:34:01 UTC
(In reply to Jens Georg from comment #5)
> Created attachment 368957 [details] [review] [review]
> Save selection before setting the restore point

Works for me.
Comment 7 Jens Georg 2018-02-27 08:47:21 UTC
Yeah. The "proper" fix would be holding a reference to "this" while doing the move transaction and reverting the fix for bug 786531. But doing manual references in Vala usually points to something being very wrong
Comment 8 Jens Georg 2018-02-27 20:45:35 UTC
Attachment 368957 [details] pushed as d5aa2a2 - Save selection before setting the restore point
Comment 9 Jens Georg 2018-03-13 19:52:48 UTC
*** Bug 794305 has been marked as a duplicate of this bug. ***