After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793552 - Pressing Shift key does not display Original Photo if previously externally-edited
Pressing Shift key does not display Original Photo if previously externally-e...
Status: RESOLVED OBSOLETE
Product: shotwell
Classification: Other
Component: library-mode
0.26.x
Other Linux
: Normal minor
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-17 22:42 UTC by saroumane
Modified: 2021-05-19 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PhotoPage: Fix showing original on externally edited photo (884 bytes, patch)
2018-02-18 16:49 UTC, Jens Georg
none Details | Review
Save selection before setting the restore point (1.31 KB, patch)
2018-02-26 17:40 UTC, Jens Georg
none Details | Review

Description saroumane 2018-02-17 22:42:03 UTC
To reproduce:

1) From any checkerboard view, double-click a photograph.

2) On the photo view, secondary-click and, in the context menu, choose **Open
With External Editor**.

3) In the external editor, make one or more easily visible changes and save
them.

4) Return to Shotwell, and notice that it (correctly) shows the modified
version of the photograph.

5) Press **Shift** and observe the results.

Notice that Shotwell doesn't display the unmodified version. (Never. Even after exiting Shotwell and reloading)


It's a more "severe" version of bug 717413 which was supposed to be fixed 7 months ago.
Comment 1 Jens Georg 2018-02-18 16:37:51 UTC
Actually it seems like the fix from bug 717413 got lost somewhere
Comment 2 Jens Georg 2018-02-18 16:47:10 UTC
Apparently it got lost during adding the Raw support with some bug fixes along the way
Comment 3 Jens Georg 2018-02-18 16:49:09 UTC
Created attachment 368520 [details] [review]
PhotoPage: Fix showing original on externally edited photo

This needs more testing if all the fixes are covered.
Comment 4 Jens Georg 2018-02-26 17:40:28 UTC
Created attachment 368956 [details] [review]
Save selection before setting the restore point

With the fix for bug 786531, setting the restore point before executing
the job would add the restore point to the list of selected items.

https://bugzilla.gnome.org/show_bug.cgi?id=793818
Comment 5 Jens Georg 2018-02-26 17:56:20 UTC
Oh sorry, wrong bug
Comment 6 GNOME Infrastructure Team 2021-05-19 15:12:15 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/shotwell/-/issues/4906.